Coding standards

itk-dev · Jan 3, 2025 · 5e82681 · 5e82681
1 parent e0c5293
commit 5e82681
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/Service/DataSynchronizationService.php b/src/Service/DataSynchronizationService.php
@@ -5,7 +5,6 @@
 use App\Entity\Account;
 use App\Entity\Client;
 use App\Entity\DataProvider;
-use App\Entity\Epic;
 use App\Entity\Invoice;
 use App\Entity\Issue;
 use App\Entity\Project;

diff --git a/src/Service/InvoicingRateReportService.php b/src/Service/InvoicingRateReportService.php
@@ -11,6 +11,8 @@
 
 class InvoicingRateReportService
 {
+    private const SECONDS_TO_HOURS = 1 / 3600;
+
     public function __construct(
         private readonly WorkerRepository $workerRepository,
         private readonly WorklogRepository $worklogRepository,
@@ -88,7 +90,7 @@ public function getInvoicingRateReport(
                 // Tally up logged hours in gathered worklogs for current period
                 $loggedHours = 0;
                 foreach ($worklogs as $worklog) {
-                    $loggedHours += ($worklog->getTimeSpentSeconds() / 60 / 60);
+                    $loggedHours += ($worklog->getTimeSpentSeconds() * self::SECONDS_TO_HOURS);
                 }
 
                 // Tally up billable logged hours in gathered worklogs for current period