Coding standards

assets/controllers/toggle-parent-child_controller.js

@@ -12,7 +12,6 @@ export default class extends Controller {
 
     displayChildrenForParentIds = [];
 
-
     svgExpand = `<svg class="svg-inline--fa fa-caret-right" aria-hidden="true" focusable="false" data-prefix="fas" data-icon="caret-right" role="img" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 256 512" data-fa-i2svg=""><path fill="currentColor" d="M246.6 278.6c12.5-12.5 12.5-32.8 0-45.3l-128-128c-9.2-9.2-22.9-11.9-34.9-6.9s-19.8 16.6-19.8 29.6l0 256c0 12.9 7.8 24.6 19.8 29.6s25.7 2.2 34.9-6.9l128-128z"></path></svg>`;
 
     svgCollapse = `<svg class="svg-inline--fa fa-caret-down" aria-hidden="true" focusable="false" data-prefix="fas" data-icon="caret-down" role="img" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 320 512" data-fa-i2svg=""><path fill="currentColor" d="M137.4 374.6c12.5 12.5 32.8 12.5 45.3 0l128-128c9.2-9.2 11.9-22.9 6.9-34.9s-16.6-19.8-29.6-19.8L32 192c-12.9 0-24.6 7.8-29.6 19.8s-2.2 25.7 6.9 34.9l128 128z"></path></svg>`;

src/Form/InvoicingRateReportType.php

@@ -24,17 +24,7 @@ public function buildForm(FormBuilderInterface $builder, array $options): void
             $yearChoices[$year] = $year;
         }
 
-$builder
-            /*->add('viewMode', EnumType::class, [
-                'required' => false,
-                'label' => 'invoicing_rate_report.select_viewmode',
-                'label_attr' => ['class' => 'label'],
-                'placeholder' => false,
-                'attr' => [
-                    'class' => 'form-element',
-                ],
-                'class' => InvoicingRateReportViewModeEnum::class,
-            ])*/
+        $builder
             ->add('year', ChoiceType::class, [
                 'label' => 'invoicing_rate_report.year',
                 'label_attr' => ['class' => 'label'],

src/Model/Reports/InvoicingRateReportData.php

@@ -16,7 +16,7 @@ class InvoicingRateReportData
     public ArrayCollection $periodAverages;
     public float $totalAverage;
     /**
-     * @var false
+     * @var bool
      */
     public bool $includeIssues;
 

src/Model/Reports/InvoicingRateReportFormData.php

@@ -5,7 +5,6 @@
 class InvoicingRateReportFormData
 {
     public WorkloadReportPeriodTypeEnum $viewPeriodType;
-    public InvoicingRateReportViewModeEnum $viewMode;
     public int $year;
     public bool $includeIssues;
 }

src/Model/Reports/InvoicingRateReportWorker.php

@@ -13,7 +13,7 @@ class InvoicingRateReportWorker extends Worker
     /** @var ArrayCollection<int, array> */
     public ArrayCollection $dataByPeriod;
 
-    /** @var ArrayCollection<int, array> */
+    /** @var ArrayCollection<string, array> */
     public ArrayCollection $projectData;
 
     public function __construct()

src/Service/InvoicingRateReportService.php

@@ -21,22 +21,21 @@ public function __construct(
     /**
      * Generates an invoicing rate report for a specific year based on various parameters.
      *
-     * @param int $year The year for which the report is generated.
-     * @param PeriodTypeEnum $viewPeriodType The period type.
-     * @param InvoicingRateReportViewModeEnum $viewMode The view mode.
-     * @param bool $includeIssues Whether to include detailed issue-level data in the report.
+     * @param int $year the year for which the report is generated
+     * @param PeriodTypeEnum $viewPeriodType the period type
+     * @param InvoicingRateReportViewModeEnum $viewMode the view mode
+     * @param bool $includeIssues whether to include detailed issue-level data in the report
      *
-     * @return InvoicingRateReportData The calculated invoicing rate report data.
+     * @return InvoicingRateReportData the calculated invoicing rate report data
      *
-     * @throws \Exception If a required worker identifier is empty.
+     * @throws \Exception if a required worker identifier is empty
      */
     public function getInvoicingRateReport(
         int $year,
         PeriodTypeEnum $viewPeriodType = PeriodTypeEnum::WEEK,
         InvoicingRateReportViewModeEnum $viewMode = InvoicingRateReportViewModeEnum::SUMMARY,
-        bool $includeIssues = false
-    ): InvoicingRateReportData
-    {
+        bool $includeIssues = false,
+    ): InvoicingRateReportData {
         $invoicingRateReportData = new InvoicingRateReportData($viewPeriodType->value);
         $invoicingRateReportData->includeIssues = $includeIssues;
         if (!$year) {
@@ -142,13 +141,10 @@ public function getInvoicingRateReport(
             $invoicingRateReportData->workers->add($invoicingRateReportWorker);
 
             $invoicingRateReportWorker->projectData->set('projects', [
-                $workerProjects ?? []
+                $workerProjects,
             ]);
-
         }
 
-
-
         // Calculate and set the total average
         $numberOfPeriods = count($invoicingRateReportData->periodAverages);
 

templates/reports/invoicing_rate_report.html.twig

@@ -115,8 +115,6 @@
                             </td>
                         {% endfor %}
 
-
-
                         {% for issueName, issueDetails in issues %}
 
                             {% if not (issueName matches '/^\\d+$/') %}
@@ -153,7 +151,6 @@
                 {% endfor %}
             {% endfor %}
 
-
             </tbody>
         {% endfor %}
         <tbody>