Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1635: Reduced product invoice entries to a single entry #130

Open
wants to merge 14 commits into
base: develop
Choose a base branch
from

Conversation

rimi-itk
Copy link
Contributor

@rimi-itk rimi-itk commented Jun 12, 2024

Link to ticket

https://leantime.itkdev.dk/dashboard/home#/tickets/showTicket/1635

Description

  • Reduces (multiple) products to a single invoice entry and prefixes with an account name.
  • Adds option to create one invoice per issue

Checklist

  • My code is covered by test cases.
  • My code passes our test (all our tests).
  • My code passes our static analysis suite.
  • My code passes our continuous integration process.

@rimi-itk rimi-itk force-pushed the feature/1635-product-invoice-lines branch from 6399009 to b15fe2f Compare June 12, 2024 08:55
@rimi-itk rimi-itk requested a review from tuj June 12, 2024 09:02
@rimi-itk rimi-itk marked this pull request as ready for review June 12, 2024 09:02
@rimi-itk rimi-itk force-pushed the feature/1635-product-invoice-lines branch 7 times, most recently from c3286ae to 5a84da7 Compare June 12, 2024 13:19
@rimi-itk rimi-itk requested a review from tuj June 12, 2024 13:21
@rimi-itk rimi-itk force-pushed the feature/1635-product-invoice-lines branch from 5224632 to cbd5821 Compare June 13, 2024 13:04
@rimi-itk rimi-itk force-pushed the feature/1635-product-invoice-lines branch 6 times, most recently from 21f33cc to 03535f4 Compare July 1, 2024 13:18
@rimi-itk rimi-itk requested a review from tuj July 1, 2024 13:23
@@ -32,7 +33,8 @@ public function __construct(
private readonly ClientHelper $clientHelper,
private readonly EntityManagerInterface $entityManager,
private readonly TranslatorInterface $translator,
private readonly InvoiceEntryHelper $invoiceEntryHelper,
private readonly InvoiceHelper $invoiceEntryHelper,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename to $invoiceHelper

@rimi-itk rimi-itk requested a review from tuj July 3, 2024 11:07
@rimi-itk rimi-itk force-pushed the feature/1635-product-invoice-lines branch 2 times, most recently from d1968a0 to db33c0c Compare July 5, 2024 10:41
@rimi-itk rimi-itk force-pushed the feature/1635-product-invoice-lines branch from db33c0c to e50011a Compare July 5, 2024 11:26
@rimi-itk rimi-itk force-pushed the feature/1635-product-invoice-lines branch from e50011a to e3495f4 Compare July 5, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants