-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1635: Reduced product invoice entries to a single entry #130
Open
rimi-itk
wants to merge
14
commits into
develop
Choose a base branch
from
feature/1635-product-invoice-lines
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rimi-itk
force-pushed
the
feature/1635-product-invoice-lines
branch
from
June 12, 2024 08:55
6399009
to
b15fe2f
Compare
tuj
approved these changes
Jun 12, 2024
rimi-itk
force-pushed
the
feature/1635-product-invoice-lines
branch
7 times, most recently
from
June 12, 2024 13:19
c3286ae
to
5a84da7
Compare
tuj
approved these changes
Jun 12, 2024
rimi-itk
force-pushed
the
feature/1635-product-invoice-lines
branch
from
June 13, 2024 13:04
5224632
to
cbd5821
Compare
rimi-itk
force-pushed
the
feature/1635-product-invoice-lines
branch
6 times, most recently
from
July 1, 2024 13:18
21f33cc
to
03535f4
Compare
tuj
approved these changes
Jul 2, 2024
@@ -32,7 +33,8 @@ public function __construct( | |||
private readonly ClientHelper $clientHelper, | |||
private readonly EntityManagerInterface $entityManager, | |||
private readonly TranslatorInterface $translator, | |||
private readonly InvoiceEntryHelper $invoiceEntryHelper, | |||
private readonly InvoiceHelper $invoiceEntryHelper, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rename to $invoiceHelper
tuj
approved these changes
Jul 3, 2024
tuj
approved these changes
Jul 3, 2024
rimi-itk
force-pushed
the
feature/1635-product-invoice-lines
branch
2 times, most recently
from
July 5, 2024 10:41
d1968a0
to
db33c0c
Compare
rimi-itk
force-pushed
the
feature/1635-product-invoice-lines
branch
from
July 5, 2024 11:26
db33c0c
to
e50011a
Compare
rimi-itk
force-pushed
the
feature/1635-product-invoice-lines
branch
from
July 5, 2024 11:40
e50011a
to
e3495f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket
https://leantime.itkdev.dk/dashboard/home#/tickets/showTicket/1635
Description
Checklist