LEAT-58: Sprint report #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeppekroghitk
changed the base branch from
develop
to
feature/api-setup-and-planning-overview
Base automatically changed from
feature/api-setup-and-planning-overview
to
feature/leantime
December 13, 2023 09:20
tuj
requested changes
Jan 2, 2024
src/Service/ApiServiceInterface.php
Outdated
| @@ -79,4 +82,10 @@ public function getIssuesDataForProject(string $projectId): array; | |||
| * @return array<AccountData> | |||
| */ | |||
| public function getAllAccountData(): array; | |||
|
|
|||
| public function getAllProjectsV2(): SprintReportProjects; | |||
There was a problem hiding this comment.
These 3 functions are already added to ProjectTrackerInterface. Remove them from ApiServiceInterface.
tuj
requested changes
Jan 3, 2024
src/Service/JiraApiService.php
Outdated
| } | ||
|
|
||
| public function getProjectVersions(string $projectId): SprintReportVersions | ||
| { | ||
| return new SprintReportVersions(); | ||
| throw new ApiServiceException('Method not implemented', 404); |
There was a problem hiding this comment.
Should be 501 error code
https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/501
|
|
||
| public function getSprintReportData(string $projectId, string $versionId): SprintReportData; | ||
|
|
||
| public function getAllProjectsV2(): SprintReportProjects; |
There was a problem hiding this comment.
Rename to getSprintReportProjects
|
|
||
| public function getAllProjectsV2(): SprintReportProjects; | ||
|
|
||
| public function getProjectV2(string $projectId): SprintReportProject; |
There was a problem hiding this comment.
Rename to getSprintReportProject
|
|
||
| public function getProjectV2(string $projectId): SprintReportProject; | ||
|
|
||
| public function getProjectVersions(string $projectId): SprintReportVersions; |
There was a problem hiding this comment.
Rename to getSprintReportProjectVersions
| $issues->add($issue); | ||
|
|
||
| // Set issue tag. | ||
| if (isset($issueEntry->tags)) { |
There was a problem hiding this comment.
Missing comment about choice of handling all tags as a single comma-separated string
src/Service/LeantimeApiService.php
Outdated
|
|
||
| // Set issue tag. | ||
| if (isset($issueEntry->tags)) { | ||
| $tagId = $this->tagToId($issueEntry->tags); |
There was a problem hiding this comment.
Suggested change
| $tagId = $this->tagToId($issueEntry->tags); | |
| $tagId = $issueEntry->tags |
tuj
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket
LEAT-58
Description
Adds leantime support for sprint report.
Checklist