Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/je 403 exceptions and cleanup #54

Merged
merged 7 commits into from
Jan 3, 2024
Merged

Feature/je 403 exceptions and cleanup #54

merged 7 commits into from
Jan 3, 2024

Conversation

tuj
Copy link
Contributor

@tuj tuj commented Dec 22, 2023 •
edited
Loading

Status

Depends on #52. Handle after that PR has been merged.

Link to ticket

https://jira.itkdev.dk/browse/JE-403

Description

  • Better exception messages to the user.
  • Cleaned up duplicated code issues.
  • Moved sync code from BillingService to DataProviderService.

Checklist

  • My code passes our static analysis suite.
  • My code passes our continuous integration process.

@tuj tuj marked this pull request as ready for review January 2, 2024 10:13
@tuj tuj requested a review from jeppekroghitk January 2, 2024 10:13
@tuj tuj merged commit dd78bcc into develop Jan 3, 2024
6 checks passed
@tuj tuj deleted the feature/je-403-exceptions-and-cleanup branch January 3, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeppekroghitk jeppekroghitk jeppekroghitk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tuj @jeppekroghitk