Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Persistence TCK userguide, signature update and code clean up. #1249

Merged
merged 1 commit into from
Mar 11, 2024
Merged

Persistence TCK userguide, signature update and code clean up. #1249

merged 1 commit into from
Mar 11, 2024

Conversation

gurunrao
Copy link
Contributor

@gurunrao gurunrao commented Mar 7, 2024

Persistence TCK userguide, signature update and code clean up.

@scottmarlow scottmarlow requested a review from lukasj March 7, 2024 15:13
scottmarlow
scottmarlow reviewed Mar 7, 2024
View reviewed changes
jpa/bin/pom.xml Outdated Show resolved Hide resolved
lukasj
lukasj reviewed Mar 11, 2024
View reviewed changes
jpa/bin/pom.xml Outdated Show resolved Hide resolved
lukasj
lukasj reviewed Mar 11, 2024
View reviewed changes
jpa/bin/pom.xml Outdated Show resolved Hide resolved
lukasj
lukasj reviewed Mar 11, 2024
View reviewed changes
jpa/bin/pom.xml Outdated Show resolved Hide resolved
@lukasj lukasj mentioned this pull request Mar 11, 2024
Merged
lukasj
lukasj reviewed Mar 11, 2024
View reviewed changes
Copy link
Contributor

@lukasj lukasj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general - looks good.

The only thing I do not like much is that there is no dependencyManagement nor pluginManagement, so it is currently more difficult to maintain versions as it could be - but that is something for another PR

@gurunrao gurunrao merged commit 553a6ee into jakartaee:tckrefactor Mar 11, 2024
2 checks passed
@gurunrao gurunrao deleted the jpa-user-guide-update branch April 17, 2024 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukasj lukasj lukasj left review comments

@scottmarlow scottmarlow scottmarlow left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gurunrao @scottmarlow @lukasj