CON-5401 Remove explicit target types for libraries #30
Conversation
teeweizhong10
requested review from
taher-mosbah,
c7bercat,
matthias-trip,
JiriMachalek and
CassieJamf
team-adder
bot
requested review from
AlexSlukin,
aprueher,
BartO-jamf,
camdenwebster,
cferris-jamf,
grandoracle,
JacobHearst,
jakubKozakW,
JakubStanglicaWND,
JanSkrabal,
johnlehouerou,
lukyratica,
macblazer and
macshome
team-adder
bot
requested review from
watkyn,
mlink,
palisladek,
pmoprhy,
RachelPolachova,
radimcervinka,
Saczuu,
sameh0,
tsfischer and
tsvoboda-wandera
| targets: [ "Subprocess" ] | ||
| ), | ||
| .library( | ||
| name: "SubprocessMocks", | ||
| type: .static, | ||
| targets: [ "SubprocessMocks" ] | ||
| ), | ||
| .library( | ||
| name: "libSubprocess", |
There was a problem hiding this comment.
There is no need for this whole .library product if the type is removed. It's identical to the Subprocess product. Same goes for libSubprocessMocks; it does not need to exist if the type is removed.
Obviously removing entire products will be a breaking change and would require a major version update.
Perhaps removing the type first with this PR, and tag this as a 3.x release. Then a separate PR removing the duplicated products which can be tagged as a 4.0 release would be the right path forward.
There was a problem hiding this comment.
Sounds good, so no other actionable items other than perhaps writing down that the duplicated products type needs to be removed? I could add it as a comment under the issue #29?
This reverts commit ec2cccb.
…ment-Container' of https://github.com/jamf/Subprocess into CON-5401-SSP-User-Info-Tile-and-Account-Management-Container
teeweizhong10
dismissed stale reviews from mlink, grandoracle, and JacobHearst
via
89fa883
|
Needed verified commits in order to merge... nothing has changed with the past few commits and it was just me figuring out how to sign my commits 😅 |
teeweizhong10
deleted the
CON-5401-SSP-User-Info-Tile-and-Account-Management-Container
branch
Addresses #29