Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CON-5401 Remove explicit target types for libraries #30

Closed
wants to merge 7 commits into from
Closed

CON-5401 Remove explicit target types for libraries #30

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ec2cccb
CON-5401 Remove explicit target types for libraries
teeweizhong10 Nov 7, 2024
37d79d5
CON-5401 Revert "CON-5401 Remove explicit target types for libraries"
teeweizhong10 Nov 17, 2024
aa37a94
CON-5401 Remove explicit target types for libraries
teeweizhong10 Nov 17, 2024
7e08d47
CON-5401 Remove explicit target types for libraries
teeweizhong10 Nov 17, 2024
14c2300
CON-5401 Merge branch 'CON-5401-SSP-User-Info-Tile-and-Account-Manage…
teeweizhong10 Nov 17, 2024
89fa883
CON-5401 Push signed commit
teeweizhong10 Nov 17, 2024
84819ca
CON-5401 Undo change for getting signed commit
teeweizhong10 Nov 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,22 +8,18 @@ let package = Package(
products: [
.library(
name: "Subprocess",
type: .static,
targets: [ "Subprocess" ]
),
.library(
name: "SubprocessMocks",
type: .static,
targets: [ "SubprocessMocks" ]
),
.library(
name: "libSubprocess",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need for this whole .library product if the type is removed. It's identical to the Subprocess product. Same goes for libSubprocessMocks; it does not need to exist if the type is removed.

Obviously removing entire products will be a breaking change and would require a major version update.

Perhaps removing the type first with this PR, and tag this as a 3.x release. Then a separate PR removing the duplicated products which can be tagged as a 4.0 release would be the right path forward.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, so no other actionable items other than perhaps writing down that the duplicated products type needs to be removed? I could add it as a comment under the issue #29?

type: .dynamic,
targets: [ "Subprocess" ]
),
.library(
name: "libSubprocessMocks",
type: .dynamic,
targets: [ "SubprocessMocks" ]
)
],
Expand Down
Loading