Fix segmentation in 1-Index #970

ignotus666 · 2023-10-20T09:20:16Z

Short description of changes
Fixes the broken up sentences in 1-Index.html (now 1-Index.md). Makes it easier to edit text in future too.

Context: Fixes an issue? Related issues
Fixes: #934

Status of this Pull Request
Tested locally and seems to be working.

What is missing until this pull request can be merged?
Further testing by someone else might be advisable.

Does this need translation?

YES

Checklist

I've verified that this Pull Request follows the general code principles
I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
I'm sure that this Pull Request goes to the correct branch

Make kramdown the markdown processor

ann0see

Interesting approach. Can you think of anything where index.md doesn't work while the html would?

ann0see · 2023-10-20T21:05:25Z

wiki/en/misc/1-index.md

+mTPlatformsAnd: 'and'
+mTOtherPlatforms: 'other platforms'
+---
+[//]: # Markdown sections should not be indented


Interesting

It gets treated as a code block otherwise.

I think it would be good to add the explanation too.

mcfnord · 2023-10-20T23:23:59Z

wiki/en/misc/1-index.md

+<div class="fx-row fx-row-center-xs" id="bannercontainer">
+  <div class="fx-col-100-xs">
+    <a href="wiki/Getting-Started">
+      <img alt="Jamulus Banner. Links to getting started page" src="{{ '/assets/img/jamulusbannersmall.png' | relative_url }}" id="jamulusbanner" loading="lazy" />


Suggested change

<img alt="Jamulus Banner. Links to getting started page" src="{{ '/assets/img/jamulusbannersmall.png' | relative_url }}" id="jamulusbanner" loading="lazy" />

<img alt="Jamulus banner. Links to getting started page" src="{{ '/assets/img/jamulusbannersmall.png' | relative_url }}" id="jamulusbanner" loading="lazy" />

I'd rather you proposed these changes in another PR. This one is to fix the segmentation issue.

It won't hurt my feelings if you ignore my proposed improvements, though I hope your view changes.

@mcfnord your proposals are fine, I agree with them - I just think they belong in a separate PR.

Does accepting the suggestions interfere with your workflow? I know they create commit messages that I don't know how to squash yet in my own PRs.

@mcfnord you can try https://www.git-tower.com/learn/git/faq/git-squash (maybe GitHub desktop/GitKraken, ... helps you? They're graphical tools which I tried both.) Also see https://blog.devart.com/best-git-gui-clients-for-windows.html)

I will study those links, and will learn to squash. I'm asking why ignotus666 won't accept these suggestions in this PR. I drive-by suggest every chance I get. I want to understand what prevents acceptance in some instances.

If for whatever reason we want to find what PR a change happened in, the PR title should give us a good clue about it. Your proposed changes have nothing to do with the purpose of this PR, which is purely to solve a technical issue. Maybe I'm wrong, but I think the policy here is to keep PRs and issues on topic and not have them branch out in all directions.

Maybe I'm wrong, but I think the policy here is to keep PRs and issues on topic and not have them branch out in all directions.

Yes. this makes discussion more focussed.

It is threaded tho. It's an empty seat and a free ride into town.

mcfnord · 2023-10-20T23:25:26Z

wiki/en/misc/1-index.md

+    <h2>Help needed?</h2>
+      <p>
+<div markdown="1">
+Check out the [documentation](wiki/Getting-Started) and consider the [troubleshooting section](wiki/Client-Troubleshooting)!


Suggested change

Check out the [documentation](wiki/Getting-Started) and consider the [troubleshooting section](wiki/Client-Troubleshooting)!

Check out [the documentation](wiki/Getting-Started) and consider the [troubleshooting section](wiki/Client-Troubleshooting)!

I try to favor larger hyperlinks rather than smaller ones because they're more noticeable and more clickable.

Even go to "Check out the documentation" as the link?

mcfnord · 2023-10-20T23:25:47Z

wiki/en/misc/1-index.md

+      <p>
+<div markdown="1">
+Check out the [documentation](wiki/Getting-Started) and consider the [troubleshooting section](wiki/Client-Troubleshooting)!
+You can also ask on the [forums](https://github.com/jamulussoftware/jamulus/discussions).


Suggested change

You can also ask on the [forums](https://github.com/jamulussoftware/jamulus/discussions).

You can also ask on [the forums](https://github.com/jamulussoftware/jamulus/discussions).

And "ask on the forums" (as that's what the link will help with).

mcfnord · 2023-10-20T23:26:11Z

wiki/en/misc/1-index.md

+    <h2>Want to get involved?</h2>
+    <p>
+<div markdown="1">
+Ideas? Found a bug? Want to contribute some code or help [translating](https://github.com/jamulussoftware/jamulus/blob/main/docs/TRANSLATING.md) Jamulus into your language? Since Jamulus is [free and open source software](https://www.gnu.org/philosophy/free-sw.en.html) (FOSS) licensed under the [GPL](https://www.gnu.org/licenses/old-licenses/gpl-2.0.en.html) you can help us!<br>


Suggested change

Ideas? Found a bug? Want to contribute some code or help [translating](https://github.com/jamulussoftware/jamulus/blob/main/docs/TRANSLATING.md) Jamulus into your language? Since Jamulus is [free and open source software](https://www.gnu.org/philosophy/free-sw.en.html) (FOSS) licensed under the [GPL](https://www.gnu.org/licenses/old-licenses/gpl-2.0.en.html) you can help us! 

Ideas? Found a bug? Want to contribute some code or [help translating](https://github.com/jamulussoftware/jamulus/blob/main/docs/TRANSLATING.md) Jamulus into your language? Since Jamulus is [free and open source software](https://www.gnu.org/philosophy/free-sw.en.html) (FOSS) licensed under the [GPL](https://www.gnu.org/licenses/old-licenses/gpl-2.0.en.html) you can help us!

ignotus666 · 2023-10-21T08:16:11Z

Interesting approach. Can you think of anything where index.md doesn't work while the html would?

In a local build everything seems to be working fine. If someone else tests it maybe they can spot something I missed.

ann0see · 2023-10-25T20:08:47Z

_po4a-tools/po4a-create-all-targets.sh

@@ -103,10 +103,10 @@ process_with_po4a () {
        if [ $ext == yml ] ; then
            FILE_FORMAT=yaml
            OPTION="skip_array"
-        elif [ $ext == html ] ; then
+        elif [[ $ext == html || "$filename" == *'-index' ]] ; then


Maybe add a comment here. also can you match on -index.md?

Will add a comment.

Yes, it matches -index.md too because it only looks at the file name excluding the extension.

_po4a-tools/po4a-update-templates.sh

Co-authored-by: Peter L Jones <[email protected]>

ann0see

Let's merge this. If ignotus is confident enough it's ok, feel free to merge that and open a new PR with the suggestions by @mcfnord

This reverts commit 256a678.

@gilgongo

* Use newlines for code to help with copy-paste (#968) * newlines help with copy-paste * use tabs rather than 4 spaces * three tics for copy button * preferred markdown * AUTO: Updated .po files * Change jamulus-server to jamulus-headless (#969) * Change jamulus-server to jamulus-headless * Fix grammar Co-authored-by: John Dempsey <[email protected]> --------- Co-authored-by: John Dempsey <[email protected]> * AUTO: Updated .po files * Fix segmentation in 1-Index (#970) * Update _config.yml Make kramdown the markdown processor * Update and rename 1-index.html to 1-index.md * Update 1-index.md * Update 1-de-index.html * Rename 1-de-index.html to 1-de-index.md * Update and rename 1-es-index.html to 1-es-index.md * Update and rename 1-fr-index.html to 1-fr-index.md * Update and rename 1-index.html to 1-index.md * Update and rename 1-it-index.html to 1-it-index.md * Update and rename 1-ko_KR-index.html to 1-ko_KR-index.md * Update and rename 1-nb_NO-index.html to 1-nb_NO-index.md * Update and rename 1-nl-index.html to 1-nl-index.md * Update and rename 1-pt_BR-index.html to 1-pt_BR-index.md * Update and rename 1-pt_PT-index.html to 1-pt_PT-index.md * Update and rename 1-zh_CN-index.html to 1-zh_CN-index.md * Fix segmentation in 1-Index * Don't include processed .po files * Correction * Add comments * Add comments * Update _po4a-tools/po4a-update-templates.sh Co-authored-by: Peter L Jones <[email protected]> * Remove unneeded check --------- Co-authored-by: Peter L Jones <[email protected]> * AUTO: Updated .po files * Revert "AUTO: Updated .po files" This reverts commit a73218e. * Revert "Fix segmentation in 1-Index (#970)" This reverts commit 256a678. * Translations update from Hosted Weblate (#975) * Update Spanish translation using Weblate Currently translated at 100.0% (159 of 159 strings) Co-authored-by: gallegonovato <[email protected]> Translate-URL: https://hosted.weblate.org/projects/jamulus/running-a-server/es/ Translation: Jamulus/Running-a-Server * Update French translation using Weblate Currently translated at 100.0% (165 of 165 strings) Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Co-authored-by: Olivier Humbert <[email protected]> Translate-URL: https://hosted.weblate.org/projects/jamulus/directories/ Translate-URL: https://hosted.weblate.org/projects/jamulus/running-a-server/fr/ Translation: Jamulus/Directories Translation: Jamulus/Running-a-Server * Update translation files Updated by "Squash Git commits" hook in Weblate. Translation: Jamulus/Running-a-Server Translate-URL: https://hosted.weblate.org/projects/jamulus/running-a-server/ --------- Co-authored-by: gallegonovato <[email protected]> Co-authored-by: Olivier Humbert <[email protected]> * Fix segmentation in 1-Index 2nd attempt (#976) * Update _config.yml Make kramdown the markdown processor * Update and rename 1-index.html to 1-index.md * Update 1-index.md * Update 1-de-index.html * Rename 1-de-index.html to 1-de-index.md * Update and rename 1-es-index.html to 1-es-index.md * Update and rename 1-fr-index.html to 1-fr-index.md * Update and rename 1-index.html to 1-index.md * Update and rename 1-it-index.html to 1-it-index.md * Update and rename 1-ko_KR-index.html to 1-ko_KR-index.md * Update and rename 1-nb_NO-index.html to 1-nb_NO-index.md * Update and rename 1-nl-index.html to 1-nl-index.md * Update and rename 1-pt_BR-index.html to 1-pt_BR-index.md * Update and rename 1-pt_PT-index.html to 1-pt_PT-index.md * Update and rename 1-zh_CN-index.html to 1-zh_CN-index.md * Fix segmentation in 1-Index * Don't include processed .po files * Correction * Add comments * Add comments * Update _po4a-tools/po4a-update-templates.sh Co-authored-by: Peter L Jones <[email protected]> * Remove unneeded check * AUTO: Updated .po files --------- Co-authored-by: Peter L Jones <[email protected]> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * AUTO: Updated .po files * Add changes to iOS install page * Translations update from Hosted Weblate (#978) * Update Installation-for-Linux.md adding PipeWire usage. (#980) * AUTO: Updated .po files * Apply suggestion Co-authored-by: Peter L Jones <[email protected]> * Update deprecated actions * Replace banner image * Add figure style * Lang select (#11) * Initial replacements testing OK so far * Add language selection dropdown * Don't store lang preference * Align dropdown to the right. Remove unneeded code from fw.css * Make dropdown scrollable * Clean/move/improve css styling, add icon, lang sel. outline * Remove unneeded css * Show full lang names, automate adding langs * AUTO: Add new language: (eu) #4 * Revert "AUTO: Add new language: (eu) #4" This reverts commit 301c948. * Correction * AUTO: Add new language: (Basque) #5 * Update add-lang.yml * AUTO: Add new language: (English (American)) #6 * Correction * Revert language additions * Correction * Correction * Update * Update * Add check * Update error message * Revert lang code hyphens * Add changes by @gilgongo * Combine with gilgongo's stuff * Correct title check * Correct pt-BR language codes * Revert lang code changes --------- Co-authored-by: Gilgongo <[email protected]> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * Replace with simplified version * Change add-lang message, remove suglang reference * Improve accessibility * Match text colour * Make dropdown menu more compact * Make dropdown standard html * Replace with simplified version Change add-lang message, remove suglang reference Improve accessibility Match text colour Make dropdown menu more compact Make dropdown standard html * Add no-JS option * Correction to no-JS list * Make non-JS selection highlighted * Add language-container to fw.css * Correct translation readme * Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Translate-URL: https://hosted.weblate.org/projects/jamulus/software-manual/ Translation: Jamulus/Software-Manual * Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Translate-URL: https://hosted.weblate.org/projects/jamulus/software-manual/ Translation: Jamulus/Software-Manual * Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Translate-URL: https://hosted.weblate.org/projects/jamulus/software-manual/ Translation: Jamulus/Software-Manual * Update translation files Updated by "Squash Git commits" hook in Weblate. Translation: Jamulus/Tips-Tricks-More Translate-URL: https://hosted.weblate.org/projects/jamulus/tips-tricks-more/ * Rephrase sentence Co-authored-by: Peter L Jones <[email protected]> * Fix canonical/alternate links * Fix canonical/alternate links * Use class for figure * Add class for home page img * Better class name Co-authored-by: ann0see <[email protected]> * Better class name Co-authored-by: ann0see <[email protected]> * Removed lrelease and .qm files check-in from release process. These steps no longer needed as .qm files are now compiled on the fly. * AUTO: Updated .po files * Update Release-Process.md Co-authored-by: ann0see <[email protected]> * Make current language non-selectable in non-JS mode * Tidy up and fix non-selectable EN * Update _includes/headtags.html Co-authored-by: ann0see <[email protected]> * Change po folders to new lang codes * Bump rexml from 3.2.8 to 3.3.2 Bumps [rexml](https://github.com/ruby/rexml) from 3.2.8 to 3.3.2. - [Release notes](https://github.com/ruby/rexml/releases) - [Changelog](https://github.com/ruby/rexml/blob/master/NEWS.md) - [Commits](ruby/rexml@v3.2.8...v3.3.2) --- updated-dependencies: - dependency-name: rexml dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> * Update dependencies * Add connection setup and advanced setup screenshots * Add connection setup and advanced setup screenshots in ES * Mention connect via menu does not force disconnect * Expand description of server list and say "directory" * Add note about delete button * Fix "My Profile" screenshot border * AUTO: Updated .po files * Fix syntax error * Update dependencies * AUTO: Add new language: sv: Svenska #999 * Revert "AUTO: Add new language: sv: Svenska #999" This reverts commit 1eb8e58. * AUTO: Add new language: sv-SE: Svenska #1022 * update-nl-images-for-3-11 * Update translation files Updated by "Squash Git commits" hook in Weblate. Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Translate-URL: https://hosted.weblate.org/projects/jamulus/directories/ Translate-URL: https://hosted.weblate.org/projects/jamulus/installation-for-ios/ Translation: Jamulus/Directories Translation: Jamulus/Installation-for-iOS * Update translation files Updated by "Squash Git commits" hook in Weblate. Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Translate-URL: https://hosted.weblate.org/projects/jamulus/directories/ Translate-URL: https://hosted.weblate.org/projects/jamulus/installation-for-ios/ Translation: Jamulus/Directories Translation: Jamulus/Installation-for-iOS * Update Italian translation using Weblate Currently translated at 100.0% (13 of 13 strings) Update translation files Updated by "Squash Git commits" hook in Weblate. Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Co-authored-by: ann0see <[email protected]> Translate-URL: https://hosted.weblate.org/projects/jamulus/1-index/it/ Translate-URL: https://hosted.weblate.org/projects/jamulus/directories/ Translate-URL: https://hosted.weblate.org/projects/jamulus/installation-for-ios/ Translation: Jamulus/Directories Translation: Jamulus/Installation-for-iOS Translation: Jamulus/Startpage * Update Dutch translation using Weblate Currently translated at 100.0% (159 of 159 strings) Translated using Weblate (Dutch) Currently translated at 100.0% (31 of 31 strings) Update Dutch translation using Weblate Currently translated at 100.0% (16 of 16 strings) Update Dutch translation using Weblate Currently translated at 100.0% (27 of 27 strings) Update Dutch translation using Weblate Currently translated at 100.0% (12 of 12 strings) Update Dutch translation using Weblate Currently translated at 100.0% (159 of 159 strings) Update translation files Updated by "Squash Git commits" hook in Weblate. Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Henk De Groot <[email protected]> Co-authored-by: Hosted Weblate <[email protected]> Translate-URL: https://hosted.weblate.org/projects/jamulus/directories/ Translate-URL: https://hosted.weblate.org/projects/jamulus/directories/nl/ Translate-URL: https://hosted.weblate.org/projects/jamulus/installation-for-ios/ Translate-URL: https://hosted.weblate.org/projects/jamulus/running-a-server/nl/ Translate-URL: https://hosted.weblate.org/projects/jamulus/server-bandwidth/nl/ Translate-URL: https://hosted.weblate.org/projects/jamulus/server-troubleshooting/nl/ Translate-URL: https://hosted.weblate.org/projects/jamulus/unregistered-servers/nl/ Translation: Jamulus/Directories Translation: Jamulus/Installation-for-iOS Translation: Jamulus/Running-a-Server Translation: Jamulus/Server-Bandwidth Translation: Jamulus/Server-Troubleshooting Translation: Jamulus/Unregistered-Servers * Update Spanish translation using Weblate Currently translated at 100.0% (137 of 137 strings) Update translation files Updated by "Squash Git commits" hook in Weblate. Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Co-authored-by: ignotus <[email protected]> Translate-URL: https://hosted.weblate.org/projects/jamulus/directories/ Translate-URL: https://hosted.weblate.org/projects/jamulus/installation-for-ios/ Translate-URL: https://hosted.weblate.org/projects/jamulus/software-manual/es/ Translation: Jamulus/Directories Translation: Jamulus/Installation-for-iOS Translation: Jamulus/Software-Manual * Update translation files Updated by "Squash Git commits" hook in Weblate. Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Translate-URL: https://hosted.weblate.org/projects/jamulus/directories/ Translate-URL: https://hosted.weblate.org/projects/jamulus/installation-for-ios/ Translation: Jamulus/Directories Translation: Jamulus/Installation-for-iOS * Update Swedish translation using Weblate Currently translated at 100.0% (16 of 16 strings) Update Swedish translation using Weblate Currently translated at 100.0% (27 of 27 strings) Update Swedish translation using Weblate Currently translated at 100.0% (12 of 12 strings) Translated using Weblate (Swedish) Currently translated at 100.0% (31 of 31 strings) Update Swedish translation using Weblate Currently translated at 100.0% (56 of 56 strings) Update Swedish translation using Weblate Currently translated at 100.0% (137 of 137 strings) Update Swedish translation using Weblate Currently translated at 100.0% (159 of 159 strings) Update Swedish translation using Weblate Currently translated at 100.0% (137 of 137 strings) Update Swedish translation using Weblate Currently translated at 100.0% (159 of 159 strings) Update translation files Updated by "Squash Git commits" hook in Weblate. Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Co-authored-by: ann0see <[email protected]> Co-authored-by: ignotus <[email protected]> Translate-URL: https://hosted.weblate.org/projects/jamulus/client-troubleshooting/sv/ Translate-URL: https://hosted.weblate.org/projects/jamulus/directories/ Translate-URL: https://hosted.weblate.org/projects/jamulus/directories/sv/ Translate-URL: https://hosted.weblate.org/projects/jamulus/installation-for-ios/ Translate-URL: https://hosted.weblate.org/projects/jamulus/running-a-server/sv/ Translate-URL: https://hosted.weblate.org/projects/jamulus/server-bandwidth/sv/ Translate-URL: https://hosted.weblate.org/projects/jamulus/server-troubleshooting/sv/ Translate-URL: https://hosted.weblate.org/projects/jamulus/software-manual/sv/ Translate-URL: https://hosted.weblate.org/projects/jamulus/unregistered-servers/sv/ Translation: Jamulus/Client-Troubleshooting Translation: Jamulus/Directories Translation: Jamulus/Installation-for-iOS Translation: Jamulus/Running-a-Server Translation: Jamulus/Server-Bandwidth Translation: Jamulus/Server-Troubleshooting Translation: Jamulus/Software-Manual Translation: Jamulus/Unregistered-Servers * Update translation files Updated by "Squash Git commits" hook in Weblate. Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Translate-URL: https://hosted.weblate.org/projects/jamulus/directories/ Translate-URL: https://hosted.weblate.org/projects/jamulus/installation-for-ios/ Translation: Jamulus/Directories Translation: Jamulus/Installation-for-iOS * Update translation files Updated by "Squash Git commits" hook in Weblate. Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Translate-URL: https://hosted.weblate.org/projects/jamulus/directories/ Translate-URL: https://hosted.weblate.org/projects/jamulus/installation-for-ios/ Translation: Jamulus/Directories Translation: Jamulus/Installation-for-iOS * Update Chinese (Simplified) translation using Weblate Currently translated at 100.0% (159 of 159 strings) Update translation files Updated by "Squash Git commits" hook in Weblate. Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Co-authored-by: ann0see <[email protected]> Translate-URL: https://hosted.weblate.org/projects/jamulus/directories/ Translate-URL: https://hosted.weblate.org/projects/jamulus/installation-for-ios/ Translate-URL: https://hosted.weblate.org/projects/jamulus/running-a-server/zh_Hans/ Translation: Jamulus/Directories Translation: Jamulus/Installation-for-iOS Translation: Jamulus/Running-a-Server * Update translation files Updated by "Squash Git commits" hook in Weblate. Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Translate-URL: https://hosted.weblate.org/projects/jamulus/directories/ Translate-URL: https://hosted.weblate.org/projects/jamulus/installation-for-ios/ Translation: Jamulus/Directories Translation: Jamulus/Installation-for-iOS * Replace bundle id * AUTO: Updated .po files * Update German translation using Weblate Currently translated at 100.0% (6 of 6 strings) Co-authored-by: ann0see <[email protected]> Translate-URL: https://hosted.weblate.org/projects/jamulus/include-client-commands/de/ Translation: Jamulus/Include-Client-Commands * Update Dutch translation using Weblate Currently translated at 100.0% (49 of 49 strings) Co-authored-by: ann0see <[email protected]> Translate-URL: https://hosted.weblate.org/projects/jamulus/installation-for-linux/nl/ Translation: Jamulus/Installation-for-Linux * Update Swedish translation using Weblate Currently translated at 100.0% (159 of 159 strings) Co-authored-by: ann0see <[email protected]> Translate-URL: https://hosted.weblate.org/projects/jamulus/running-a-server/sv/ Translation: Jamulus/Running-a-Server * Update Portuguese (Portugal) translation using Weblate Currently translated at 100.0% (13 of 13 strings) Co-authored-by: ann0see <[email protected]> Translate-URL: https://hosted.weblate.org/projects/jamulus/1-index/pt_PT/ Translation: Jamulus/Startpage * Identify canonical and alternate URLs (#1026) Co-authored-by: ann0see <[email protected]> * Update Gemfile version numbers * Add closing / to standalone HTML tags, for po4a parser. (#1037) The po4a XML parser seems to dislike standalone HTML tags such as <img> and , and this causes it to mis-parse tags that enclose them. This commit changes <img> to <img/> and to , which keeps the parser happy. * AUTO: Updated .po files * Fix for jekyll canonical URL construction (#1039) * Add language directories in _data and wiki to .gitignore Only en and en-no-translate are committed to Github * Update download links on the website --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: John Dempsey <[email protected]> Co-authored-by: ignotus <[email protected]> Co-authored-by: Peter L Jones <[email protected]> Co-authored-by: Weblate (bot) <[email protected]> Co-authored-by: gallegonovato <[email protected]> Co-authored-by: Olivier Humbert <[email protected]> Co-authored-by: Julien Taverna <[email protected]> Co-authored-by: Jonathan <[email protected]> Co-authored-by: Gilgongo <[email protected]> Co-authored-by: Tony Mountifield <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Peter L Jones <[email protected]> Co-authored-by: Henk De Groot <[email protected]> Co-authored-by: Henk De Groot <[email protected]> Co-authored-by: ignotus <[email protected]>

ignotus666 added 17 commits October 20, 2023 08:39

Update _config.yml

774ebb9

Make kramdown the markdown processor

Update and rename 1-index.html to 1-index.md

de920b4

Update 1-index.md

d5309b3

Update 1-de-index.html

08726f8

Rename 1-de-index.html to 1-de-index.md

e8c67b0

Update and rename 1-es-index.html to 1-es-index.md

88e8bd6

Update and rename 1-fr-index.html to 1-fr-index.md

9b46ec1

Update and rename 1-index.html to 1-index.md

226c57e

Update and rename 1-it-index.html to 1-it-index.md

5b10333

Update and rename 1-ko_KR-index.html to 1-ko_KR-index.md

87fdbbd

Update and rename 1-nb_NO-index.html to 1-nb_NO-index.md

200581a

Update and rename 1-nl-index.html to 1-nl-index.md

5f3ecc3

Update and rename 1-pt_BR-index.html to 1-pt_BR-index.md

b4e0840

Update and rename 1-pt_PT-index.html to 1-pt_PT-index.md

badd5c2

Update and rename 1-zh_CN-index.html to 1-zh_CN-index.md

87f1af4

Fix segmentation in 1-Index

f771563

Don't include processed .po files

4377c3d

ignotus666 requested a review from ann0see October 20, 2023 09:27

Correction

0ef9de6

ann0see reviewed Oct 20, 2023

View reviewed changes

mcfnord reviewed Oct 20, 2023

View reviewed changes

ann0see reviewed Oct 25, 2023

View reviewed changes

ignotus666 added 2 commits October 26, 2023 11:27

Add comments

09acf7b

Add comments

997d39b

pljones reviewed Oct 27, 2023

View reviewed changes

_po4a-tools/po4a-update-templates.sh Outdated Show resolved Hide resolved

Update _po4a-tools/po4a-update-templates.sh

1f75c96

Co-authored-by: Peter L Jones <[email protected]>

Remove unneeded check

3ddf4ea

ann0see reviewed Nov 22, 2023

View reviewed changes

ignotus666 merged commit 256a678 into jamulussoftware:next-release Nov 22, 2023
1 check passed

ignotus666 added a commit that referenced this pull request Dec 1, 2023

Revert "Fix segmentation in 1-Index (#970)"

9ddd997

This reverts commit 256a678.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix segmentation in 1-Index #970

Fix segmentation in 1-Index #970

ignotus666 commented Oct 20, 2023 •

edited

Loading

ann0see left a comment

ann0see Oct 20, 2023

ignotus666 Oct 21, 2023

ann0see Oct 25, 2023

ignotus666 Oct 26, 2023

mcfnord Oct 20, 2023

ignotus666 Oct 21, 2023

mcfnord Oct 21, 2023

ignotus666 Oct 23, 2023

mcfnord Oct 23, 2023

ann0see Oct 25, 2023 •

edited

Loading

mcfnord Oct 26, 2023

ignotus666 Oct 26, 2023

ann0see Oct 26, 2023

mcfnord Oct 28, 2023

mcfnord Oct 20, 2023

pljones Oct 21, 2023

mcfnord Oct 21, 2023

mcfnord Oct 20, 2023

pljones Oct 21, 2023

mcfnord Oct 21, 2023 •

edited

Loading

mcfnord Oct 20, 2023

ignotus666 commented Oct 21, 2023

ann0see Oct 25, 2023

ignotus666 Oct 26, 2023

ann0see left a comment

	<img alt="Jamulus Banner. Links to getting started page" src="{{ '/assets/img/jamulusbannersmall.png' \| relative_url }}" id="jamulusbanner" loading="lazy" />
	<img alt="Jamulus banner. Links to getting started page" src="{{ '/assets/img/jamulusbannersmall.png' \| relative_url }}" id="jamulusbanner" loading="lazy" />

	Check out the [documentation](wiki/Getting-Started) and consider the [troubleshooting section](wiki/Client-Troubleshooting)!
	Check out [the documentation](wiki/Getting-Started) and consider the [troubleshooting section](wiki/Client-Troubleshooting)!

	You can also ask on the [forums](https://github.com/jamulussoftware/jamulus/discussions).
	You can also ask on [the forums](https://github.com/jamulussoftware/jamulus/discussions).

	Ideas? Found a bug? Want to contribute some code or help [translating](https://github.com/jamulussoftware/jamulus/blob/main/docs/TRANSLATING.md) Jamulus into your language? Since Jamulus is [free and open source software](https://www.gnu.org/philosophy/free-sw.en.html) (FOSS) licensed under the [GPL](https://www.gnu.org/licenses/old-licenses/gpl-2.0.en.html) you can help us!<br>
	Ideas? Found a bug? Want to contribute some code or [help translating](https://github.com/jamulussoftware/jamulus/blob/main/docs/TRANSLATING.md) Jamulus into your language? Since Jamulus is [free and open source software](https://www.gnu.org/philosophy/free-sw.en.html) (FOSS) licensed under the [GPL](https://www.gnu.org/licenses/old-licenses/gpl-2.0.en.html) you can help us!<br>

Fix segmentation in 1-Index #970

Fix segmentation in 1-Index #970

Conversation

ignotus666 commented Oct 20, 2023 • edited Loading

Checklist

ann0see left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ann0see Oct 25, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mcfnord Oct 21, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ignotus666 commented Oct 21, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ann0see left a comment

Choose a reason for hiding this comment

ignotus666 commented Oct 20, 2023 •

edited

Loading

ann0see Oct 25, 2023 •

edited

Loading

mcfnord Oct 21, 2023 •

edited

Loading