-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix segmentation in 1-Index #970
Changes from all commits
774ebb9
de920b4
d5309b3
08726f8
e8c67b0
88e8bd6
9b46ec1
226c57e
5b10333
87fdbbd
200581a
5f3ecc3
b4e0840
badd5c2
87f1af4
f771563
4377c3d
0ef9de6
09acf7b
997d39b
1f75c96
3ddf4ea
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
wiki/de/1-index.md |
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
wiki/es/1-index.md |
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
wiki/fr/1-index.md |
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
wiki/en/misc/1-index.md |
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
wiki/it/1-index.md |
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
wiki/it/1-index.md |
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
wiki/nb_NO/1-index.md |
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
wiki/nl/1-index.md |
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
wiki/pt_BR/1-index.md |
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
wiki/pt_PT/1-index.md |
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
wiki/zh_CN/1-index.md |
This file was deleted.
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -0,0 +1,64 @@ | ||||||
--- | ||||||
title: "Jamulus ‒ Play music online. With friends. For free." | ||||||
lang: "en" | ||||||
permalink: / | ||||||
layout: mainhomepage | ||||||
ldjAppCategory: "Music" | ||||||
ldjSlogan: "Play music online. With friends. For free." | ||||||
ldjCreator: "Volker Fischer and contributors" | ||||||
metadescription: "Jamulus is free and open source software that lets musicians perform music, rehearse or jam together, in real time over the Internet." | ||||||
mAltProgIcon: "Jamulus icon" | ||||||
mTSlogan: "Play music online. With friends. For free." | ||||||
mTGetStartedNow: "Get started now!" | ||||||
mTDownloadNow: 'Download now for' | ||||||
mTPlatformsAnd: 'and' | ||||||
mTOtherPlatforms: 'other platforms' | ||||||
--- | ||||||
[//]: # Markdown sections should not be indented, otherwise they are treated as code blocks. | ||||||
<div class="fx-row fx-row-center-xs" id="firstrow"> | ||||||
<div class="fx-col-100-xs"> | ||||||
<div itemprop="abstract"> | ||||||
<h2>What is Jamulus?</h2> | ||||||
<div markdown="1"> | ||||||
Jamulus lets you play, rehearse, or jam with your friends, your band, or anyone you find online. Play together remotely in time with high quality, low-latency sound on a normal broadband connection. [Download it here!](wiki/Getting-Started) | ||||||
</div> | ||||||
</div> | ||||||
</div> | ||||||
</div> | ||||||
<div class="fx-row fx-row-center-xs" id="bannercontainer"> | ||||||
<div class="fx-col-100-xs"> | ||||||
<a href="wiki/Getting-Started"> | ||||||
<img alt="Jamulus Banner. Links to getting started page" src="{{ '/assets/img/jamulusbannersmall.png' | relative_url }}" id="jamulusbanner" loading="lazy" /> | ||||||
</a> | ||||||
</div> | ||||||
</div> | ||||||
<div class="fx-row fx-row-center-xs"> | ||||||
<div class="fx-col-100-xs fx-col-50-l"> | ||||||
<h2>Jamulus worldwide</h2> | ||||||
<div markdown="1"> | ||||||
All over the world Jamulus allows choirs to rehearse and rock bands to play. Jamulus brings folk and classical musicians together. It's being used for remote music lessons, in schools and universities, in private and in public — all in real time on the Internet, as if you were there in person. | ||||||
</div> | ||||||
<h2>Help needed?</h2> | ||||||
<p> | ||||||
<div markdown="1"> | ||||||
Check out the [documentation](wiki/Getting-Started) and consider the [troubleshooting section](wiki/Client-Troubleshooting)! | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
I try to favor larger hyperlinks rather than smaller ones because they're more noticeable and more clickable. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Even go to "Check out the documentation" as the link? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe so. |
||||||
You can also ask on the [forums](https://github.com/jamulussoftware/jamulus/discussions). | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. And "ask on the forums" (as that's what the link will help with). There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe so. |
||||||
</div> | ||||||
</p> | ||||||
</div> | ||||||
<div class="fx-col-100-xs fx-col-50-l"> | ||||||
<h2>Want to get involved?</h2> | ||||||
<p> | ||||||
<div markdown="1"> | ||||||
Ideas? Found a bug? Want to contribute some code or help [translating](https://github.com/jamulussoftware/jamulus/blob/main/docs/TRANSLATING.md) Jamulus into your language? Since Jamulus is [free and open source software](https://www.gnu.org/philosophy/free-sw.en.html) (FOSS) licensed under the [GPL](https://www.gnu.org/licenses/old-licenses/gpl-2.0.en.html) you can help us!<br> | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
<br> | ||||||
Take a look at our [contribution guidelines](wiki/Contribution) to find out how. Everybody is welcome!<br> | ||||||
<br> | ||||||
_For detailed information on how Jamulus works, see [this paper by Volker Fischer (PDF)](/PerformingBandRehearsalsontheInternetWithJamulus.pdf)._ | ||||||
</div> | ||||||
</p> | ||||||
</div> | ||||||
<div class="fx-col-100-xs fx-txt-center"> | ||||||
<a href="wiki/Getting-Started" class="button" rel="noreferrer">{{ page.mTGetStartedNow }}</a> | ||||||
</div> | ||||||
</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rather you proposed these changes in another PR. This one is to fix the segmentation issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It won't hurt my feelings if you ignore my proposed improvements, though I hope your view changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mcfnord your proposals are fine, I agree with them - I just think they belong in a separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does accepting the suggestions interfere with your workflow? I know they create commit messages that I don't know how to squash yet in my own PRs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mcfnord you can try https://www.git-tower.com/learn/git/faq/git-squash (maybe GitHub desktop/GitKraken, ... helps you? They're graphical tools which I tried both.) Also see https://blog.devart.com/best-git-gui-clients-for-windows.html)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will study those links, and will learn to squash. I'm asking why ignotus666 won't accept these suggestions in this PR. I drive-by suggest every chance I get. I want to understand what prevents acceptance in some instances.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If for whatever reason we want to find what PR a change happened in, the PR title should give us a good clue about it. Your proposed changes have nothing to do with the purpose of this PR, which is purely to solve a technical issue. Maybe I'm wrong, but I think the policy here is to keep PRs and issues on topic and not have them branch out in all directions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. this makes discussion more focussed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is threaded tho. It's an empty seat and a free ride into town.