Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix segmentation in 1-Index #970

Merged
merged 22 commits into from
Nov 22, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
774ebb9
Update _config.yml
ignotus666 Oct 20, 2023
de920b4
Update and rename 1-index.html to 1-index.md
ignotus666 Oct 20, 2023
d5309b3
Update 1-index.md
ignotus666 Oct 20, 2023
08726f8
Update 1-de-index.html
ignotus666 Oct 20, 2023
e8c67b0
Rename 1-de-index.html to 1-de-index.md
ignotus666 Oct 20, 2023
88e8bd6
Update and rename 1-es-index.html to 1-es-index.md
ignotus666 Oct 20, 2023
9b46ec1
Update and rename 1-fr-index.html to 1-fr-index.md
ignotus666 Oct 20, 2023
226c57e
Update and rename 1-index.html to 1-index.md
ignotus666 Oct 20, 2023
5b10333
Update and rename 1-it-index.html to 1-it-index.md
ignotus666 Oct 20, 2023
87fdbbd
Update and rename 1-ko_KR-index.html to 1-ko_KR-index.md
ignotus666 Oct 20, 2023
200581a
Update and rename 1-nb_NO-index.html to 1-nb_NO-index.md
ignotus666 Oct 20, 2023
5f3ecc3
Update and rename 1-nl-index.html to 1-nl-index.md
ignotus666 Oct 20, 2023
b4e0840
Update and rename 1-pt_BR-index.html to 1-pt_BR-index.md
ignotus666 Oct 20, 2023
badd5c2
Update and rename 1-pt_PT-index.html to 1-pt_PT-index.md
ignotus666 Oct 20, 2023
87f1af4
Update and rename 1-zh_CN-index.html to 1-zh_CN-index.md
ignotus666 Oct 20, 2023
f771563
Fix segmentation in 1-Index
ignotus666 Oct 20, 2023
4377c3d
Don't include processed .po files
ignotus666 Oct 20, 2023
0ef9de6
Correction
ignotus666 Oct 20, 2023
09acf7b
Add comments
ignotus666 Oct 26, 2023
997d39b
Add comments
ignotus666 Oct 27, 2023
1f75c96
Update _po4a-tools/po4a-update-templates.sh
ignotus666 Oct 27, 2023
3ddf4ea
Remove unneeded check
ignotus666 Oct 27, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion 1-de-index.html

This file was deleted.

1 change: 1 addition & 0 deletions 1-de-index.md
1 change: 0 additions & 1 deletion 1-es-index.html

This file was deleted.

1 change: 1 addition & 0 deletions 1-es-index.md
1 change: 0 additions & 1 deletion 1-fr-index.html

This file was deleted.

1 change: 1 addition & 0 deletions 1-fr-index.md
1 change: 0 additions & 1 deletion 1-index.html

This file was deleted.

1 change: 1 addition & 0 deletions 1-index.md
1 change: 0 additions & 1 deletion 1-it-index.html

This file was deleted.

1 change: 1 addition & 0 deletions 1-it-index.md
1 change: 0 additions & 1 deletion 1-ko_KR-index.html

This file was deleted.

1 change: 1 addition & 0 deletions 1-ko_KR-index.md
1 change: 0 additions & 1 deletion 1-nb_NO-index.html

This file was deleted.

1 change: 1 addition & 0 deletions 1-nb_NO-index.md
1 change: 0 additions & 1 deletion 1-nl-index.html

This file was deleted.

1 change: 1 addition & 0 deletions 1-nl-index.md
1 change: 0 additions & 1 deletion 1-pt_BR-index.html

This file was deleted.

1 change: 1 addition & 0 deletions 1-pt_BR-index.md
1 change: 0 additions & 1 deletion 1-pt_PT-index.html

This file was deleted.

1 change: 1 addition & 0 deletions 1-pt_PT-index.md
1 change: 0 additions & 1 deletion 1-zh_CN-index.html

This file was deleted.

1 change: 1 addition & 0 deletions 1-zh_CN-index.md
57 changes: 31 additions & 26 deletions Gemfile.lock
Original file line number Diff line number Diff line change
@@ -1,37 +1,39 @@
GEM
remote: https://rubygems.org/
specs:
addressable (2.8.1)
addressable (2.8.5)
public_suffix (>= 2.0.2, < 6.0)
colorator (1.1.0)
concurrent-ruby (1.1.10)
concurrent-ruby (1.2.2)
cssminify2 (2.0.1)
em-websocket (0.5.3)
eventmachine (>= 0.12.9)
http_parser.rb (~> 0)
eventmachine (1.2.7)
execjs (2.8.1)
ffi (1.15.5)
execjs (2.9.1)
ffi (1.16.3)
forwardable-extended (2.6.0)
google-protobuf (3.24.4)
htmlcompressor (0.4.0)
http_parser.rb (0.8.0)
i18n (1.12.0)
i18n (1.14.1)
concurrent-ruby (~> 1.0)
jekyll (4.2.2)
jekyll (4.3.2)
addressable (~> 2.4)
colorator (~> 1.0)
em-websocket (~> 0.5)
i18n (~> 1.0)
jekyll-sass-converter (~> 2.0)
jekyll-sass-converter (>= 2.0, < 4.0)
jekyll-watch (~> 2.0)
kramdown (~> 2.3)
kramdown (~> 2.3, >= 2.3.1)
kramdown-parser-gfm (~> 1.0)
liquid (~> 4.0)
mercenary (~> 0.4.0)
mercenary (>= 0.3.6, < 0.5)
pathutil (~> 0.9)
rouge (~> 3.0)
rouge (>= 3.0, < 5.0)
safe_yaml (~> 1.0)
terminal-table (~> 2.0)
terminal-table (>= 1.8, < 4.0)
webrick (~> 1.7)
jekyll-minifier (0.1.10)
cssminify2 (~> 2.0)
htmlcompressor (~> 0.4)
Expand All @@ -40,40 +42,43 @@ GEM
uglifier (~> 4.1)
jekyll-paginate-v2 (3.0.0)
jekyll (>= 3.0, < 5.0)
jekyll-polyglot (1.5.1)
jekyll (>= 3.0)
jekyll-sass-converter (2.2.0)
sassc (> 2.0.1, < 3.0)
jekyll-polyglot (1.6.0)
jekyll (>= 4.0, >= 3.0)
jekyll-sass-converter (3.0.0)
sass-embedded (~> 1.54)
jekyll-watch (2.2.1)
listen (~> 3.0)
json (2.6.2)
json (2.6.3)
json-minify (0.0.3)
json (> 0)
kramdown (2.4.0)
rexml
kramdown-parser-gfm (1.1.0)
kramdown (~> 2.0)
liquid (4.0.3)
listen (3.7.1)
liquid (4.0.4)
listen (3.8.0)
rb-fsevent (~> 0.10, >= 0.10.3)
rb-inotify (~> 0.9, >= 0.9.10)
mercenary (0.4.0)
pathutil (0.16.2)
forwardable-extended (~> 2.6)
public_suffix (5.0.0)
public_suffix (5.0.3)
rake (13.0.6)
rb-fsevent (0.11.2)
rb-inotify (0.10.1)
ffi (~> 1.0)
rexml (3.2.5)
rouge (3.30.0)
rexml (3.2.6)
rouge (4.1.3)
safe_yaml (1.0.5)
sassc (2.4.0)
ffi (~> 1.9)
terminal-table (2.0.0)
unicode-display_width (~> 1.1, >= 1.1.1)
sass-embedded (1.69.4)
google-protobuf (~> 3.23)
rake (>= 13.0.0)
terminal-table (3.0.2)
unicode-display_width (>= 1.1.1, < 3)
uglifier (4.2.0)
execjs (>= 0.3.0, < 3)
unicode-display_width (1.8.0)
unicode-display_width (2.5.0)
webrick (1.8.1)

PLATFORMS
ruby
Expand Down
3 changes: 3 additions & 0 deletions _config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ default_lang: "en"
exclude_from_localization: ["assets", "images", "css", "README.md", "manifest.json", "humans.txt", "sitemap.xml", "robots.txt", "404.html", "CNAME", "LICENSE.md"]
parallel_localization: true
a_rootpage: "https://jamulus.io"
markdown: kramdown
kramdown:
input: GFM

# Jamulus release binary links
download_root_link: "https://github.com/jamulussoftware/jamulus/releases/download/r3_10_0/"
Expand Down
8 changes: 4 additions & 4 deletions _po4a-tools/po4a-add-language.sh
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,13 @@ echo Creating .po files for "$new_lang"
# Go to root directory
cd ../

# Create symlinks for 1-index.html file
ln -s -r ./wiki/$new_lang/1-index.html ./1-$new_lang-index.html
# Create symlinks for 1-index.md file
ln -s -r ./wiki/$new_lang/1-index.md ./1-$new_lang-index.md
if [ $(echo $?) == 0 ] ; then
echo ''
echo 1-"$new_lang"-index.html symlink created for "$new_lang" in /
echo 1-"$new_lang"-index.md symlink created for "$new_lang" in /
else
echo Error creating 1-"$new_lang"-index.html symlink in /
echo Error creating 1-"$new_lang"-index.md symlink in /
exit 1
fi

Expand Down
10 changes: 5 additions & 5 deletions _po4a-tools/po4a-create-all-targets.sh
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ process_with_po4a () {
if [ $ext == yml ] ; then
FILE_FORMAT=yaml
OPTION="skip_array"
elif [ $ext == html ] ; then
elif [[ $ext == html || "$filename" == *'-index' ]] ; then # '-index.md' has a markdown extension but is actually html and should be processed as such by po4a
FILE_FORMAT=xml
OPTION="ontagerror=warn"
elif [ $ext == md ] ; then
Expand All @@ -128,11 +128,11 @@ process_with_po4a () {
echo "$filename.$ext" translated into "$lang"
fi

# Check if language is set correctly in '1-$lang-index.html'
# Check if language is set correctly in '1-$lang-index.md'
if [ $filename == '1-index' ] ; then
if ! grep -Fxq 'lang: "'$lang'"' "$WIKI_DIR/$lang/1-index.html" ; then
echo replacing incorrect language tag in 1-"$lang"-index.html;
sed -i '0,/lang: "[^"]*"/s/lang: "[^"]*"/lang: "'$lang'"/' "$WIKI_DIR/$lang/1-index.html"
if ! grep -Fxq 'lang: "'$lang'"' "$WIKI_DIR/$lang/1-index.md" ; then
echo replacing incorrect language tag in 1-"$lang"-index.md;
sed -i '0,/lang: "[^"]*"/s/lang: "[^"]*"/lang: "'$lang'"/' "$WIKI_DIR/$lang/1-index.md"
fi
fi

Expand Down
2 changes: 1 addition & 1 deletion _po4a-tools/po4a-update-templates.sh
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ while IFS= read -r -d '' doc ; do
if [ $ext == yml ] ; then
FILE_FORMAT=yaml
OPTION="skip_array"
elif [ $ext == html ] ; then
elif [[ $ext == html || "$filename" == *'-index' ]] ; then # '-index.md' has a markdown extension but is actually html and should be processed as such by po4a
FILE_FORMAT=xml
OPTION="ontagerror=warn"
elif [ $ext == md ] ; then
Expand Down
60 changes: 0 additions & 60 deletions wiki/en/misc/1-index.html

This file was deleted.

64 changes: 64 additions & 0 deletions wiki/en/misc/1-index.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,64 @@
---
title: "Jamulus ‒ Play music online. With friends. For free."
lang: "en"
permalink: /
layout: mainhomepage
ldjAppCategory: "Music"
ldjSlogan: "Play music online. With friends. For free."
ldjCreator: "Volker Fischer and contributors"
metadescription: "Jamulus is free and open source software that lets musicians perform music, rehearse or jam together, in real time over the Internet."
mAltProgIcon: "Jamulus icon"
mTSlogan: "Play music online. With friends. For free."
mTGetStartedNow: "Get started now!"
mTDownloadNow: 'Download now for'
mTPlatformsAnd: 'and'
mTOtherPlatforms: 'other platforms'
---
[//]: # Markdown sections should not be indented, otherwise they are treated as code blocks.
<div class="fx-row fx-row-center-xs" id="firstrow">
<div class="fx-col-100-xs">
<div itemprop="abstract">
<h2>What is Jamulus?</h2>
<div markdown="1">
Jamulus lets you play, rehearse, or jam with your friends, your band, or anyone you find online. Play together remotely in time with high quality, low-latency sound on a normal broadband connection. [Download it here!](wiki/Getting-Started)
</div>
</div>
</div>
</div>
<div class="fx-row fx-row-center-xs" id="bannercontainer">
<div class="fx-col-100-xs">
<a href="wiki/Getting-Started">
<img alt="Jamulus Banner. Links to getting started page" src="{{ '/assets/img/jamulusbannersmall.png' | relative_url }}" id="jamulusbanner" loading="lazy" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<img alt="Jamulus Banner. Links to getting started page" src="{{ '/assets/img/jamulusbannersmall.png' | relative_url }}" id="jamulusbanner" loading="lazy" />
<img alt="Jamulus banner. Links to getting started page" src="{{ '/assets/img/jamulusbannersmall.png' | relative_url }}" id="jamulusbanner" loading="lazy" />

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather you proposed these changes in another PR. This one is to fix the segmentation issue.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It won't hurt my feelings if you ignore my proposed improvements, though I hope your view changes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mcfnord your proposals are fine, I agree with them - I just think they belong in a separate PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does accepting the suggestions interfere with your workflow? I know they create commit messages that I don't know how to squash yet in my own PRs.

Copy link
Member

@ann0see ann0see Oct 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mcfnord you can try https://www.git-tower.com/learn/git/faq/git-squash (maybe GitHub desktop/GitKraken, ... helps you? They're graphical tools which I tried both.) Also see https://blog.devart.com/best-git-gui-clients-for-windows.html)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will study those links, and will learn to squash. I'm asking why ignotus666 won't accept these suggestions in this PR. I drive-by suggest every chance I get. I want to understand what prevents acceptance in some instances.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If for whatever reason we want to find what PR a change happened in, the PR title should give us a good clue about it. Your proposed changes have nothing to do with the purpose of this PR, which is purely to solve a technical issue. Maybe I'm wrong, but I think the policy here is to keep PRs and issues on topic and not have them branch out in all directions.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I'm wrong, but I think the policy here is to keep PRs and issues on topic and not have them branch out in all directions.

Yes. this makes discussion more focussed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is threaded tho. It's an empty seat and a free ride into town.

</a>
</div>
</div>
<div class="fx-row fx-row-center-xs">
<div class="fx-col-100-xs fx-col-50-l">
<h2>Jamulus worldwide</h2>
<div markdown="1">
All over the world Jamulus allows choirs to rehearse and rock bands to play. Jamulus brings folk and classical musicians together. It's being used for remote music lessons, in schools and universities, in private and in public — all in real time on the Internet, as if you were there in person.
</div>
<h2>Help needed?</h2>
<p>
<div markdown="1">
Check out the [documentation](wiki/Getting-Started) and consider the [troubleshooting section](wiki/Client-Troubleshooting)!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Check out the [documentation](wiki/Getting-Started) and consider the [troubleshooting section](wiki/Client-Troubleshooting)!
Check out [the documentation](wiki/Getting-Started) and consider the [troubleshooting section](wiki/Client-Troubleshooting)!

I try to favor larger hyperlinks rather than smaller ones because they're more noticeable and more clickable.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even go to "Check out the documentation" as the link?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe so.

You can also ask on the [forums](https://github.com/jamulussoftware/jamulus/discussions).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
You can also ask on the [forums](https://github.com/jamulussoftware/jamulus/discussions).
You can also ask on [the forums](https://github.com/jamulussoftware/jamulus/discussions).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And "ask on the forums" (as that's what the link will help with).

Copy link
Contributor

@mcfnord mcfnord Oct 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe so.

</div>
</p>
</div>
<div class="fx-col-100-xs fx-col-50-l">
<h2>Want to get involved?</h2>
<p>
<div markdown="1">
Ideas? Found a bug? Want to contribute some code or help [translating](https://github.com/jamulussoftware/jamulus/blob/main/docs/TRANSLATING.md) Jamulus into your language? Since Jamulus is [free and open source software](https://www.gnu.org/philosophy/free-sw.en.html) (FOSS) licensed under the [GPL](https://www.gnu.org/licenses/old-licenses/gpl-2.0.en.html) you can help us!<br>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Ideas? Found a bug? Want to contribute some code or help [translating](https://github.com/jamulussoftware/jamulus/blob/main/docs/TRANSLATING.md) Jamulus into your language? Since Jamulus is [free and open source software](https://www.gnu.org/philosophy/free-sw.en.html) (FOSS) licensed under the [GPL](https://www.gnu.org/licenses/old-licenses/gpl-2.0.en.html) you can help us!<br>
Ideas? Found a bug? Want to contribute some code or [help translating](https://github.com/jamulussoftware/jamulus/blob/main/docs/TRANSLATING.md) Jamulus into your language? Since Jamulus is [free and open source software](https://www.gnu.org/philosophy/free-sw.en.html) (FOSS) licensed under the [GPL](https://www.gnu.org/licenses/old-licenses/gpl-2.0.en.html) you can help us!<br>

<br>
Take a look at our [contribution guidelines](wiki/Contribution) to find out how. Everybody is welcome!<br>
<br>
_For detailed information on how Jamulus works, see [this paper by Volker Fischer (PDF)](/PerformingBandRehearsalsontheInternetWithJamulus.pdf)._
</div>
</p>
</div>
<div class="fx-col-100-xs fx-txt-center">
<a href="wiki/Getting-Started" class="button" rel="noreferrer">{{ page.mTGetStartedNow }}</a>
</div>
</div>