Disable the explanations #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe I missed it, but I thought the idea was to show actual text rather than disabling them? |
|
Ultimately, but we don't have that text yet. So for now I like Jonas' suggestion. |
vandenman
reviewed
Sep 14, 2023
| @@ -207,7 +207,6 @@ LSTdecisionTree <- function(jaspResults, dataset = NULL, options) { | |||
|
|
|||
| jaspResults[["DecisionTree"]] <- createJaspContainer("") | |||
| jaspResults[["DecisionTree"]][["Heading"]] <- plot1 | |||
| jaspResults[["DecisionTree"]][["Text"]] <- createJaspHtml("Some explanation and maybe a link to the test?", "p") | |||
There was a problem hiding this comment.
If the idea is that there should be actual text in here at some point (just now now), I would leave this as a comment like:
# jaspResults[["DecisionTree"]][["Text"]] <- createJaspHtml("Some explanation and maybe a link to the test?", "p") # TODO: write an informative explanation.The word TODO is easy to search for.
If there should never be any text here, then I would indeed remove it.
There was a problem hiding this comment.
I didn't discuss this with anyone yet, but IMO there should be some text and (if possible) a link to test or at least a description where to find it in JASP. So I'll do as you suggested!
vandenman
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the explanations for now by disabling the checkboxes. They are default off and cannot be clicked. I thought it was still okay to keep them visible, so people see this feature will come?