Merge pull request #1698 from jdi-testing/issue_1495-plugin-crash-whe…

…n-select-element Issue 1495: fix plugin crash when select 1 element from context menu
jdi-testing · Apr 2, 2024 · 6344ef8 · 6344ef8
2 parents 86531eb + b59be58
commit 6344ef8
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 5 deletions.
diff --git a/manifest.json b/manifest.json
@@ -3,7 +3,7 @@
   "name": "JDN — Page Object Generator",
   "description": "JDN – helps Test Automation Engineer to create Page Objects in the test automation framework and speed up test development",
   "devtools_page": "index.html",
-  "version": "3.15.17",
+  "version": "3.15.18",
   "icons": {
     "128": "icon128.png"
   },

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "jdn-ai-chrome-extension",
-  "version": "3.15.17",
+  "version": "3.15.18",
   "description": "jdn-ai chrome extension",
   "scripts": {
     "start": "webpack --watch --env devenv",

diff --git a/src/pageServices/contentScripts/contextmenu.js b/src/pageServices/contentScripts/contextmenu.js
@@ -524,7 +524,10 @@ export const runContextMenu = () => {
           elementMenu.hide();
           return sendMessage({
             message: ScriptMsg.ElementSelect,
-            param: _element,
+            param: {
+              chosenElem: _element,
+              otherElems: predictedElements,
+            },
           });
         },
       },

diff --git a/src/pageServices/scriptMessageHandler.ts b/src/pageServices/scriptMessageHandler.ts
@@ -51,7 +51,8 @@ export const updateMessageHandler = (
       copyLocator(framework, value, pageObjectName, option)();
     },
     [ScriptMsg.ElementSelect]: (payload) => {
-      dispatch(elementSetActive(payload.element_id));
+      dispatch(elementGroupUnsetActive(payload.otherElems));
+      dispatch(elementSetActive(payload.chosenElem));
     },
     [ScriptMsg.ElementGroupSetActive]: (payload) => {
       const locators = payload.map((jdnHash: string) => selectLocatorByJdnHash(state, jdnHash));