better description of disqus and google analytics setup #853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashmaroli
reviewed
Mar 5, 2025
| @@ -252,7 +252,7 @@ Optionally, if you have a Disqus account, you can tell Jekyll to use it to show | |||
|
|
|||
| :warning: `url`, e.g. `https://example.com`, must be set in you config file for Disqus to work. | |||
|
|
|||
| To enable it, after setting the url field, you also need to add the following lines to your Jekyll site: | |||
| To enable it, after setting the url field, you need to add the following lines to your `_config.yml`: | |||
|
|
|||
| ```yaml | |||
| disqus: | |||
There was a problem hiding this comment.
there are additional whitespaces here (before key disqus) as well.
| @@ -310,10 +310,10 @@ The full list of available social icons can be found at https://fontawesome.com/ | |||
|
|
|||
| ### Enabling Google Analytics | |||
|
|
|||
| To enable Google Analytics, add the following lines to your Jekyll site: | |||
| To enable Google Analytics, after you set up your account there, add your measurement id the to your `_config.yml`: | |||
There was a problem hiding this comment.
Too many commas in my opinion.
Suggested change
| To enable Google Analytics, after you set up your account there, add your measurement id the to your `_config.yml`: | |
| To enable Google Analytics, first set up your account at Google Analytics and then add your *measurement id* the to | |
| your `_config.yml`: |
I feel linking to the GA documentation would be better as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from the wording it wasn't very clear where exactly should users put the lines for configuration (Jekyll site doesn't say much), added some details.
Also Google Analytics id now looks different and starts with G instead, also changed