Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better description of disqus and google analytics setup #853

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

better description of disqus and google analytics setup #853

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2573883
better description of disqus and google analytics setup
Polovinkin Feb 24, 2025
a8c5861
Merge branch 'master' into patch-1
Polovinkin Mar 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ Optionally, if you have a Disqus account, you can tell Jekyll to use it to show

:warning: `url`, e.g. `https://example.com`, must be set in you config file for Disqus to work.

To enable it, after setting the url field, you also need to add the following lines to your Jekyll site:
To enable it, after setting the url field, you need to add the following lines to your `_config.yml`:

```yaml
disqus:
Copy link
Member

@ashmaroli ashmaroli Mar 5, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are additional whitespaces here (before key disqus) as well.

Expand Down Expand Up @@ -310,10 +310,10 @@ The full list of available social icons can be found at https://fontawesome.com/

### Enabling Google Analytics

To enable Google Analytics, add the following lines to your Jekyll site:
To enable Google Analytics, after you set up your account there, add your measurement id the to your `_config.yml`:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too many commas in my opinion.

Suggested change
To enable Google Analytics, after you set up your account there, add your measurement id the to your `_config.yml`:
To enable Google Analytics, first set up your account at Google Analytics and then add your *measurement id* the to
your `_config.yml`:

I feel linking to the GA documentation would be better as well.


```yaml
google_analytics: UA-NNNNNNNN-N
google_analytics: G-NNNNNNNNNN
```

Google Analytics will only appear in production, i.e., `JEKYLL_ENV=production`
Expand Down