Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] CDR data reader #264

Merged
merged 25 commits into from
Dec 19, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
939e19c
Implemented Read and ReadCondition CDR methods
jmmorato Dec 13, 2024
571456e
Implemented Take and TakeWithCondition CDR
jmmorato Dec 14, 2024
e935150
Merge branch 'develop' into feature/cdr_data_reader
jmmorato Dec 14, 2024
a3ab01f
Implemented Read/Take Instance CDR methods
jmmorato Dec 14, 2024
c2fae17
Implemented ReadNextInstance and TakeNextInstance CDR methods
jmmorato Dec 14, 2024
0300a52
Back to Cdecl convention
jmmorato Dec 17, 2024
9ed55bb
Implemented LookupInstance and GetKeyValue CDR methods
jmmorato Dec 17, 2024
e7fa586
Bump NuGet package version
jmmorato Dec 17, 2024
55a737c
Temporlly removed frameworks
jmmorato Dec 17, 2024
ff301d5
Changed unit test path
jmmorato Dec 17, 2024
b5e2cfa
Commented code for testing
jmmorato Dec 17, 2024
fc52569
Test only simplest overload
jmmorato Dec 18, 2024
1c9d4c9
Do not call ReadNextInstance
jmmorato Dec 18, 2024
84abf80
Ignore test
jmmorato Dec 18, 2024
e3f1856
Ignore TestTakeNextInstance as well
jmmorato Dec 18, 2024
f44c8ca
Remove Ignore and comment writing samples
jmmorato Dec 18, 2024
96d0400
Use private publisher
jmmorato Dec 18, 2024
f48e11e
Do not wait for acknowledgments
jmmorato Dec 18, 2024
38e2f61
Use internal class publisher for all tests
jmmorato Dec 18, 2024
5c91b11
Remove write from TestReadNextInstance
jmmorato Dec 18, 2024
dd27cf3
Don't recycle Duration object
jmmorato Dec 18, 2024
631f69e
Wait with sleep
jmmorato Dec 18, 2024
2f35f59
Write only one sample
jmmorato Dec 18, 2024
8fb010b
Use LibraryImport only for NET8 and greater
jmmorato Dec 18, 2024
6a3f1f8
Use NET8_0_OR_GREATER for LibraryImport
jmmorato Dec 18, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .github/workflows/ci_standard.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -80,16 +80,12 @@ jobs:
if: steps.opendds-libraries-windows.outputs.cache-hit != 'true'
run: ${{ github.workspace }}/Build/OpenDDSharp.Build.ps1 --BuildConfiguration=${{ matrix.BuildConfiguration }} --BuildPlatform=${{ matrix.BuildPlatform }} --OpenDdsVersion=${{ env.OpenDdsVersion }} --IgnoreThirdPartySetup=False --IgnoreThirdPartyBuild=False --VisualStudioVersion=VS2022
working-directory: ${{ github.workspace }}/Build
env:
_NO_DEBUG_HEAP: 1

- name: Build & Test with Cake (Cached)
shell: pwsh
if: steps.opendds-libraries-windows.outputs.cache-hit == 'true'
run: ${{ github.workspace }}/Build/OpenDDSharp.Build.ps1 --BuildConfiguration=${{ matrix.BuildConfiguration }} --BuildPlatform=${{ matrix.BuildPlatform }} --OpenDdsVersion=${{ env.OpenDdsVersion }} --IgnoreThirdPartySetup=True --IgnoreThirdPartyBuild=True --VisualStudioVersion=VS2022
working-directory: ${{ github.workspace }}/Build
env:
_NO_DEBUG_HEAP: 1

- name: Test Report
uses: dorny/test-reporter@v1
Expand Down
6 changes: 3 additions & 3 deletions Build/OpenDDSharp.Build/OpenDDSharp.Build.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,12 @@

<ItemGroup>
<!-- Analyzer API for our custom checks. -->
<PackageReference Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.11.0">
<PackageReference Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.12.0">
<PrivateAssets>all</PrivateAssets>
</PackageReference>

<!-- Third-party analyzers included. -->
<PackageReference Include="Microsoft.CodeAnalysis.NetAnalyzers" Version="8.0.0">
<PackageReference Include="Microsoft.CodeAnalysis.NetAnalyzers" Version="9.0.0">
<PrivateAssets>all</PrivateAssets>
</PackageReference>
<PackageReference Include="StyleCop.Analyzers" Version="1.1.118">
Expand All @@ -39,7 +39,7 @@
<PrivateAssets>all</PrivateAssets>
</PackageReference>

<PackageReference Include="Microsoft.VisualStudio.Threading.Analyzers" Version="17.11.20">
<PackageReference Include="Microsoft.VisualStudio.Threading.Analyzers" Version="17.12.19">
<PrivateAssets>all</PrivateAssets>
</PackageReference>
</ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion Build/OpenDDSharp.Build/Tasks/TestTask.cs
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ public override void Run(BuildContext context)
context.Log.Information("Starting test task...");

var solutionFullPath = Path.GetFullPath(BuildContext.OPENDDSHARP_SOLUTION_FOLDER);
var path = Path.Combine(solutionFullPath, $"Tests/OpenDDSharp.UnitTest/bin/{context.BuildConfiguration}/net6.0/{context.RunTime}");
var path = Path.Combine(solutionFullPath, $"Tests/OpenDDSharp.UnitTest/bin/{context.BuildConfiguration}/net8.0/{context.RunTime}");
context.Log.Information($"Unit test path: {path}");
var testAdapterPath = Path.Combine(BuildContext.OPENDDSHARP_SOLUTION_FOLDER, "packages/coverlet.collector/6.0.2/build/netstandard2.0");
var settingsFile = Path.Combine(solutionFullPath, "Tests.runsettings");
Expand Down
6 changes: 3 additions & 3 deletions Examples/ConsoleDemoCore/ConsoleDemoCore.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,12 @@
<ProjectReference Include="..\..\Tests\TestIdlJson\TestIdlJson.csproj" />

<!-- Analyzer API for our custom checks. -->
<PackageReference Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.11.0">
<PackageReference Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.12.0">
<PrivateAssets>all</PrivateAssets>
</PackageReference>

<!-- Third-party analyzers included. -->
<PackageReference Include="Microsoft.CodeAnalysis.NetAnalyzers" Version="8.0.0">
<PackageReference Include="Microsoft.CodeAnalysis.NetAnalyzers" Version="9.0.0">
<PrivateAssets>all</PrivateAssets>
</PackageReference>
<PackageReference Include="StyleCop.Analyzers" Version="1.1.118">
Expand All @@ -30,7 +30,7 @@
<PrivateAssets>all</PrivateAssets>
</PackageReference>

<PackageReference Include="Microsoft.VisualStudio.Threading.Analyzers" Version="17.11.20">
<PackageReference Include="Microsoft.VisualStudio.Threading.Analyzers" Version="17.12.19">
<PrivateAssets>all</PrivateAssets>
</PackageReference>
</ItemGroup>
Expand Down
Loading
Loading