Added Half-Normal & Log-Normal Distributions #1063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Max <[email protected]>
Signed-off-by: mschrader15 <[email protected]>
|
Nice, thanks. I'll look into merging this soon. |
jkleckner
reviewed
Nov 4, 2023
| There are two ways to initialize this object. The first is to pass in | ||
| the tensor of probablity parameters, at which point they can immediately be | ||
| used. The second is to not pass in the rate parameters and then call | ||
| either `fit` or `summary` + `from_summaries`, at which point the probability |
There was a problem hiding this comment.
Nit: summary -> summarize
jkleckner
reviewed
Nov 4, 2023
| There are two ways to initialize this object. The first is to pass in | ||
| the tensor of probablity parameters, at which point they can immediately be | ||
| used. The second is to not pass in the rate parameters and then call | ||
| either `fit` or `summary` + `from_summaries`, at which point the probability |
Signed-off-by: Max <[email protected]>
|
Sorry for the delay in approval. Would you mind adding in unit tests, of the style of the other distributions? |
|
Otherwise this LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a use case for a mixture model of half-normal & lognormal distributions. I did a quick implementation by sub-classing the normal distribution.
Missing tests, but this suffices for my use-case