Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] cleared miss match between default option and label in articles filter #45106

Open
wants to merge 5 commits into
base: 5.2-dev
Choose a base branch
from

Conversation

Dileepadari
Copy link

@Dileepadari Dileepadari commented Mar 10, 2025

Pull Request for Issue #37841

Summary of Changes

The default label for the articles filter in the user login has been updated to align with the actual default option (ID Descending). Previously, the label was incorrectly set to TITLE Ascending, while the functionality still followed ID Descending. This fix ensures that the label correctly reflects the selected sorting order.

Testing Instructions

  1. Navigate to: your.domain/index.php?option=com_content&view=form&layout=edit
  2. Select Article as the Menu Item Type (default is CMS content).
  3. A modal window with articles will open.
  4. Check the default filter dropdown—it should now correctly display ID Descending as both the label and the actual sorting option.

Actual result BEFORE applying this Pull Request

  • The default filter label was incorrectly set to TITLE Ascending, while the actual sorting used ID Descending.
    before

Expected result AFTER applying this Pull Request

  • Both the label and the selected option now correctly show ID Descending (ensuring that the latest articles appear first).
    after

Link to Documentation

  • Documentation link for docs.joomla.org: <link>

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org: <link>

  • No documentation changes for manual.joomla.org needed

@Dileepadari Dileepadari changed the title cleared miss match between default option and label in articles filter [5.2] cleared miss match between default option and label in articles filter Mar 10, 2025
@richard67
Copy link
Member

@Dileepadari If you check the changed files of this PR on GitHub here, you will see that you also changed the file permissions from 644 to 755. Could you revert that?
2025-03-12_pr-45106_unwanted-mode-change

@Dileepadari
Copy link
Author

Dileepadari commented Mar 13, 2025

Thanks for pointing it out, I changed the permissions back to 644. Also please let me know should I use the same pr to clear the other two issues too or can we merge this?

@QuyTon
Copy link
Contributor

QuyTon commented Mar 15, 2025

I have tested this item ✅ successfully on 37cf38b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45106.

@fgsw
Copy link

fgsw commented Mar 15, 2025

@Dileepadari

as far as i know:

Merging a branch in your Pull Request invalidate test result (you see the result of @QuyTon is gone in the checks).

Better to wait for a second successfully test and set to "Ready to Commit" (RTC) by a maintainer. After setting RTC merging the branch doesn't harm test results.

@Dileepadari
Copy link
Author

@fgsw Thank you for informing me about this. I’ll wait for the next test. I initially thought the PR needed to be rebased to stay updated, but now I understand the process better. I’ll keep that in mind going forward.

@fgsw
Copy link

fgsw commented Mar 15, 2025

I have tested this item ✅ successfully on 1bf3379

Test by using custom update server of prebuilt packages.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45106.

@QuyTon
Copy link
Contributor

QuyTon commented Mar 15, 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45106.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-5.2-dev RTC This Pull Request is Ready To Commit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants