-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.2] cleared miss match between default option and label in articles filter #45106
base: 5.2-dev
Are you sure you want to change the base?
Conversation
@Dileepadari If you check the changed files of this PR on GitHub here, you will see that you also changed the file permissions from 644 to 755. Could you revert that? |
Thanks for pointing it out, I changed the permissions back to 644. Also please let me know should I use the same pr to clear the other two issues too or can we merge this? |
I have tested this item ✅ successfully on 37cf38b This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45106. |
as far as i know: Merging a branch in your Pull Request invalidate test result (you see the result of @QuyTon is gone in the checks). Better to wait for a second successfully test and set to "Ready to Commit" (RTC) by a maintainer. After setting RTC merging the branch doesn't harm test results. |
@fgsw Thank you for informing me about this. I’ll wait for the next test. I initially thought the PR needed to be rebased to stay updated, but now I understand the process better. I’ll keep that in mind going forward. |
I have tested this item ✅ successfully on 1bf3379 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45106. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45106. |
Pull Request for Issue #37841
Summary of Changes
The default label for the articles filter in the user login has been updated to align with the actual default option (ID Descending). Previously, the label was incorrectly set to TITLE Ascending, while the functionality still followed ID Descending. This fix ensures that the label correctly reflects the selected sorting order.
Testing Instructions
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to Documentation
Documentation link for docs.joomla.org:
<link>
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
<link>
No documentation changes for manual.joomla.org needed