Remove Salt icon color and style overrides #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7e5a45d The changes in this PR will be included in the next version bump. This PR includes changesets to release 24 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
joshwooding
reviewed
Sep 20, 2023
| export interface IconProps { | ||
| /** Additional class name for root class override. */ | ||
| className?: string; | ||
| /** Name of the icon */ | ||
| name: IconNames; | ||
| /** Size of Icon */ | ||
| size?: 'small' | 'medium' | 'large'; |
There was a problem hiding this comment.
Do teams use Icon directly? If so will this cause adoption issues? It it worth supporting both and then mapping to the new values?
There was a problem hiding this comment.
I couldn't find any uses of it in the main docs repo
There was a problem hiding this comment.
It would be safer to keep this but I don't know if its necessary
There was a problem hiding this comment.
I think we should keep it for now.
DavieReid
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the overrides for Salt Icon color and size.
The color override is stopping the color prop from working on the Salt site, (added here: jpmorganchase/salt-ds#2462). The Salt icon will now use currentColor by default, so the override shouldn't be needed anymore.
The Mosaic Icon now uses number for size to align with Salt.