Breadcrumbs after update #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8b34251 The changes in this PR will be included in the next version bump. This PR includes changesets to release 24 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
DavieReid
commented
Sep 28, 2023
DavieReid
force-pushed
the
breadcrumbs-after-update
branch
from
1b0de24 to
e7b1a26
Compare
mark-tate
approved these changes
Sep 28, 2023
Pull Request Test Coverage Report for Build 6338989550
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #492
The breadcrumbs were still not showing up from a cold start.
This PR introduces a new plugin lifecycle method
shouldUpdateNamespaceSources.When a source updates, other sources that share the same namespace will re-run
afterUpdateif there is any plugin that returns true whenshouldUpdateNamespaceSourcesis called.This allows the other source to have a more holistic view of the namespace pages.