Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breadcrumbs after update #494

Merged
merged 8 commits into from
Sep 28, 2023
Merged

Breadcrumbs after update #494

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
bf5a4f8
feat: re-run `afterUpdate` when plugin requests to clear fs cache
DavieReid Sep 27, 2023
52da3b2
fix: `shouldClearCache` returning true stops processing of other plugins
DavieReid Sep 27, 2023
88dd5ec
feat: `BreadcrumbsPlugin` should clear cache
DavieReid Sep 27, 2023
eb0c333
feat: add `shouldUpdateNamespaceSources` plugin lifecycle method
DavieReid Sep 28, 2023
aaf60aa
feat: call `shouldUpdateNamespaceSources` when a source updates
DavieReid Sep 28, 2023
e7b1a26
refactor: breadcrumbs uses `shouldUpdateNamespaceSources`
DavieReid Sep 28, 2023
50e504f
test: update SourceManager tests
DavieReid Sep 28, 2023
8b34251
chore: add changeset
DavieReid Sep 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion packages/core/src/Source.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,11 @@ export default class Source {
* Called when another source (not this one) has changed.
* This source can then ask its plugins if they also want to clear their cache in response to the other source's change.
*/
async requestCacheClear(updatedSourceFilesystem: IVolumeImmutable) {
async requestCacheClear(
updatedSourceFilesystem: IVolumeImmutable,
sharedFilesystem: IVolumeImmutable,
globalConfig: MutableData<unknown>
) {
const initTime = new Date().getTime();
const shouldInvokeAfterUpdate = await this.#pluginApi.shouldClearCache(
updatedSourceFilesystem,
Expand All @@ -130,6 +134,9 @@ export default class Source {
}
if (shouldInvokeAfterUpdate === true) {
this.filesystem.clearCache();
this.filesystem.unfreeze();
await this.invokeAfterUpdate(sharedFilesystem, globalConfig);
DavieReid marked this conversation as resolved.
Show resolved Hide resolved
this.filesystem.freeze();
}
}

Expand Down
7 changes: 5 additions & 2 deletions packages/core/src/SourceManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,6 @@ export default class SourceManager {
if (!sourceActive) {
return;
}

await source.invokeAfterUpdate(this.#sharedFilesystem, this.#globalConfig);

// After each async operation, we should check if anything has caused the Source to close
Expand Down Expand Up @@ -217,7 +216,11 @@ export default class SourceManager {
return Promise.all(
Array.from(this.#sources.values()).map(existingSource => {
if (existingSource !== source && existingSource.filesystem.frozen) {
return existingSource.requestCacheClear(immutableSourceFilesystem);
return existingSource.requestCacheClear(
immutableSourceFilesystem,
this.#sharedFilesystem,
this.#globalConfig
);
}
return existingSource;
})
Expand Down