Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide a mechanism to swap out built-in component icons to custom icons #4002

Merged
merged 2 commits into from
Oct 8, 2024
Merged

Provide a mechanism to swap out built-in component icons to custom icons #4002

merged 2 commits into from
Oct 8, 2024

Conversation

Vineet119
Copy link
Contributor

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 19, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 07db4f2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@salt-ds/core Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Aug 19, 2024

@Vineet119 is attempting to deploy a commit to the FED Team Team on Vercel.

A member of the Team first needs to authorize it.

@Vineet119 Vineet119 changed the title Replacing internal salt icon Provide a mechanism to swap out built-in component icons to custom icons Aug 19, 2024
@Vineet119
Copy link
Contributor Author

/release-pr

@origami-z
Copy link
Contributor

/release-pr

@github-actions GitHub Actions
Copy link
Contributor

🫰✨ Thanks @origami-z! Your snapshot has been published to npm.

Test the snapshot by updating your package.json with the newly published version:

yarn add @salt-ds/[email protected]

@origami-z
Copy link
Contributor

Marking as draft as test is still ongoing

@origami-z origami-z marked this pull request as draft August 20, 2024 09:18
@origami-z
Copy link
Contributor

/release-pr

@github-actions GitHub Actions
Copy link
Contributor

🫰✨ Thanks @origami-z! Your snapshot has been published to npm.

Test the snapshot by updating your package.json with the newly published version:

yarn add @salt-ds/[email protected]

@Vineet119
Copy link
Contributor Author

Tested in PEPPER, looks good

@origami-z
Copy link
Contributor

/release-pr

@github-actions GitHub Actions
Copy link
Contributor

🫰✨ Thanks @origami-z! Your snapshot has been published to npm.

Test the snapshot by updating your package.json with the newly published version:

yarn add @salt-ds/[email protected]

@vercel Vercel
Copy link

vercel bot commented Aug 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
saltdesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 8, 2024 9:58pm

origami-z
origami-z reviewed Aug 23, 2024
View reviewed changes
Copy link
Contributor

@origami-z origami-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to fix CI error

packages/core/src/semantic-icon-provider/SemanticIconProvider.tsx Show resolved Hide resolved
packages/core/src/semantic-icon-provider/SemanticIconProvider.tsx Show resolved Hide resolved
packages/core/src/semantic-icon-provider/SemanticIconProvider.tsx Show resolved Hide resolved
packages/core/stories/semantic-icon-provider/semantic-icon-provider.mdx Outdated Show resolved Hide resolved
site/docs/components/semantic-icon-provider/index.mdx Outdated Show resolved Hide resolved
site/docs/components/semantic-icon-provider/index.mdx Show resolved Hide resolved
site/docs/components/semantic-icon-provider/index.mdx Outdated Show resolved Hide resolved
origami-z
origami-z previously approved these changes Sep 9, 2024
View reviewed changes
@origami-z origami-z marked this pull request as ready for review September 9, 2024 08:42
@origami-z origami-z added the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Sep 9, 2024
@github-actions github-actions bot removed the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Sep 9, 2024
joshwooding
joshwooding requested changes Sep 13, 2024
View reviewed changes
packages/core/src/link/Link.tsx Outdated Show resolved Hide resolved
@origami-z origami-z marked this pull request as draft September 26, 2024 09:17
@origami-z origami-z marked this pull request as ready for review October 1, 2024 11:22
@origami-z origami-z added the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Oct 1, 2024
@origami-z
Copy link
Contributor

Adding Chromatic to see diff

@github-actions github-actions bot removed the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Oct 1, 2024
origami-z
origami-z previously approved these changes Oct 1, 2024
View reviewed changes
origami-z
origami-z previously approved these changes Oct 8, 2024
View reviewed changes
@joshwooding joshwooding force-pushed the replacing-internal-salt-icon branch 2 times, most recently from bd00f64 to 7ee59bb Compare October 8, 2024 20:46
@joshwooding joshwooding force-pushed the replacing-internal-salt-icon branch 2 times, most recently from 761e862 to d5a54c4 Compare October 8, 2024 21:27
@joshwooding joshwooding added the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Oct 8, 2024
@joshwooding joshwooding force-pushed the replacing-internal-salt-icon branch from d5a54c4 to 07db4f2 Compare October 8, 2024 21:35
@github-actions github-actions bot removed the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Oct 8, 2024
@joshwooding joshwooding merged commit 97215f7 into jpmorganchase:main Oct 8, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshwooding joshwooding joshwooding approved these changes

@mark-tate mark-tate mark-tate approved these changes

@origami-z origami-z origami-z left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Vineet119 @origami-z @mark-tate @joshwooding