-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Handsontable to 7.1.0 #318
base: master
Are you sure you want to change the base?
Conversation
5a354fb
to
6c1c2dc
Compare
@trshafer I really appreciate you taking the initiative to put the PR together and drive the licensing discussion forward. I've somewhat moved on to other projects recently, and this library hasn't received the attention it deserves. Let me know if you're interested in remaining involved, and we can discuss how to collaborate going forward. |
Hey @jrowen, thanks for your kind words. I'm interested in pushing the license conversation forward and am happy to do this work to update this package to the most up to date handsontable version, potentially supporting multiple versions if necessary. I'm away next week, but will likely be able come back to this the following week. However, I am not interested in actively maintaining this package. I don't use |
916fe8c
to
93fb056
Compare
Copy Handsontable LICENSE.txt file from https://github.com/handsontable/handsontable/blob/22dc4bd29f61ecd9611f7ff6869acaff0dcb1839/LICENSE.txt
93fb056
to
cf69018
Compare
Hey @jrowen, I have added the LICENSE file along with the source as requested by handsontable/handsontable#6110 (comment). I have also updated the Readme and License.note file to reflect the change in the license. The Readme now provides instructions for versioning the installation of rhandsontable. |
For what it's worth, I really like the idea of at least keeping a version of this project available for free commercial use, which I think means doing one of the following:
The last option would be most difficult for users, while the second option sounds most difficult for maintainers. |
@himanga Do you feel the workaround proposed in the readme would work? https://github.com/jrowen/rhandsontable/pull/318/files#diff-04c6e90faac2675aa89e2176d2eec7d8 |
Support licenseKey for new license model of Handsontable Address height and width issue with new Handsontable Handsontable version 7.0.0 changes the license model. https://github.com/handsontable/handsontable/releases/tag/7.0.0
cf69018
to
06f0c27
Compare
@trshafer, I suspect that most packages that are on CRAN are used without thinking about licensing. Not to say users should't look at the readme, but I think the default installation should not lead people to use code incorrectly. Maybe asking users to pass the phrase 'non-commercial-and-evaluation' themselves is enough to prevent that, but now the default installation wouldn't be functional. What if both packages were installed, and the user had the option to switch to version 7.x if they pass a license key or the non-commercial phase? |
I believe @timelyportfolio is also working on a solution here that would support multiple versions of the underlying JS library. |
Is this still a possibility ? seems like other wrappers are taking same approach by indicating a license key is required for commercial use. |
I validated that this works with the rhandsontable_corr example.
You may need to update this license as handsontable license updated. I didn't look into this.
I opted not to include the non-commercial license as the default because I felt it was better to require each user to be explicit that their usage falls under the non-commercial license.
Fixes #317