Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Handsontable to 7.1.0 #318

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

trshafer
Copy link

@trshafer trshafer commented Jun 23, 2019

I validated that this works with the rhandsontable_corr example.

You may need to update this license as handsontable license updated. I didn't look into this.

I opted not to include the non-commercial license as the default because I felt it was better to require each user to be explicit that their usage falls under the non-commercial license.

Fixes #317

@jrowen
Copy link
Owner

jrowen commented Jul 18, 2019

@trshafer I really appreciate you taking the initiative to put the PR together and drive the licensing discussion forward. I've somewhat moved on to other projects recently, and this library hasn't received the attention it deserves. Let me know if you're interested in remaining involved, and we can discuss how to collaborate going forward.

@trshafer
Copy link
Author

Hey @jrowen, thanks for your kind words. I'm interested in pushing the license conversation forward and am happy to do this work to update this package to the most up to date handsontable version, potentially supporting multiple versions if necessary. I'm away next week, but will likely be able come back to this the following week.

However, I am not interested in actively maintaining this package. I don't use R in my day job and that will make it difficult for me to remain dedicated to the proper maintenance of this package going forward. I think if you have moved on from being able to dedicate time to this project, which I can totally understand, it makes sense to add a maintainers needed section to the Readme.

@trshafer trshafer force-pushed the handsontable-7-1-0 branch 2 times, most recently from 916fe8c to 93fb056 Compare July 28, 2019 20:48
@trshafer trshafer force-pushed the handsontable-7-1-0 branch from 93fb056 to cf69018 Compare July 28, 2019 20:57
@trshafer
Copy link
Author

Hey @jrowen, I have added the LICENSE file along with the source as requested by handsontable/handsontable#6110 (comment). I have also updated the Readme and License.note file to reflect the change in the license. The Readme now provides instructions for versioning the installation of rhandsontable.

@himanga
Copy link

himanga commented Aug 8, 2019

For what it's worth, I really like the idea of at least keeping a version of this project available for free commercial use, which I think means doing one of the following:

  • Stick with version 6.x
  • Maintain multiple versions of this package, not sure how to implement this except in separate repositories.
  • Separate the installation of this package from the handsontable

The last option would be most difficult for users, while the second option sounds most difficult for maintainers.

@trshafer
Copy link
Author

trshafer commented Aug 8, 2019

@himanga Do you feel the workaround proposed in the readme would work? https://github.com/jrowen/rhandsontable/pull/318/files#diff-04c6e90faac2675aa89e2176d2eec7d8

Support licenseKey for new license model of Handsontable
Address height and width issue with new Handsontable

Handsontable version 7.0.0 changes the license model.
https://github.com/handsontable/handsontable/releases/tag/7.0.0
@trshafer trshafer force-pushed the handsontable-7-1-0 branch from cf69018 to 06f0c27 Compare August 9, 2019 00:41
@himanga
Copy link

himanga commented Aug 9, 2019

@trshafer, I suspect that most packages that are on CRAN are used without thinking about licensing. Not to say users should't look at the readme, but I think the default installation should not lead people to use code incorrectly. Maybe asking users to pass the phrase 'non-commercial-and-evaluation' themselves is enough to prevent that, but now the default installation wouldn't be functional. What if both packages were installed, and the user had the option to switch to version 7.x if they pass a license key or the non-commercial phase?

@jrowen
Copy link
Owner

jrowen commented Aug 9, 2019

I believe @timelyportfolio is also working on a solution here that would support multiple versions of the underlying JS library.

@sclewis23
Copy link

Is this still a possibility ? seems like other wrappers are taking same approach by indicating a license key is required for commercial use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

handsontable version 7.1.0
4 participants