show event end time on schedule #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At DEF CON this year I found it inconvenient to have to click into an event to see when it ends. I wanted to prioritize events like talks that lasts around an hour, over events like CTFs that last all day which I can go check out later. This PR adds the end times of the events in schedule.
In addition I noticed that on chrome 00:00 is displayed as 24:00. I think it's more common to have 00:00.
I have also made PRs for this feature for the iOS and Android version: PR for iOS, PR for Android.
Screenshots from Chrome: