PR to fix iss2 #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next step will be to put the actual logic in to the default correctly, then comment out / remove the _build_server sub all together.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a pretty simple fix, however:
I was never able to determine why the override of server didn't work, or at least why it's build method was never called. I would have liked to found the reason, because I think it would be a more elegant solution than the one I've provided (changing from lazy build to a
defaultsubroutine). At this point I've simply run out of time to dig deeper.I did not include any new tests for this. I looked at the tests provided, and they should at least encompass this, as the test should fail. I would like to add some tests based off of using Test::LWP::UserAgent, but am also time constricted to do this.