Add Dockerfile highlighting #56
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sobak
force-pushed
the
feature/lang-dockerfile
branch
2 times, most recently
from
3888dc8
to
d6bc835
Compare
kadet1090
requested changes
Feb 4, 2024
Language/Dockerfile.php
Outdated
| ]; | ||
|
|
||
| $this->rules->add('keyword', new Rule( | ||
| new RegexMatcher('/^\s*\b(' . implode('|', $keywords) . ')\b/mi'), |
There was a problem hiding this comment.
Not sure if that \b is required since it must be first word of a line? The same goes for the last one - it should probably be \s as I don't think that syntax like RUN["test"] is a valid one? Not sure however.
Language/Dockerfile.php
Outdated
| { | ||
| return [ | ||
| 'name' => ['dockerfile'], | ||
| 'extension' => ['Dockerfile'], |
There was a problem hiding this comment.
This could use also other common formats like *.Dockerfile, *-Dockerfile, Dockerfile-*.
Tests/LanguagesTest.php
Outdated
Comment on lines
20
to
22
| private $_languageOverrides = [ | ||
| '*.Dockerfile' => 'dockerfile', | ||
| ]; |
There was a problem hiding this comment.
This only ensures me that it should be simply in extensions metadata because it just feels hacky.
Sobak
force-pushed
the
feature/lang-dockerfile
branch
from
d6bc835
to
e47f902
Compare
Sobak
force-pushed
the
feature/lang-dockerfile
branch
from
e47f902
to
9fc94ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remaining:
As for 0.10.0, I propose to merge this PR to master (eventually), then to branch off with
0.9.xand then we can continue 0.10.x development on master.I can even take care of porting changes back and forth, if that ever becomes a necessity because I feel like 0.9.x would be getting just bugfixes and/or new languages, not the bigger changes anyways.