Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues/29 add record state #31

Merged
merged 11 commits into from
Dec 13, 2023
Merged

Issues/29 add record state #31

merged 11 commits into from
Dec 13, 2023

Conversation

kostobog
Copy link

@kostobog kostobog commented Dec 7, 2023 •
edited
Loading

#29 - Implement generic record state.

@kostobog kostobog requested review from blcham and LaChope December 7, 2023 16:18
blcham
blcham reviewed Dec 7, 2023
View reviewed changes
src/main/resources/model.ttl Outdated Show resolved Hide resolved
src/main/resources/model.ttl Outdated Show resolved Hide resolved
@blcham blcham mentioned this pull request Dec 7, 2023
Closed
@blcham blcham self-requested a review December 8, 2023 09:13
blcham
blcham approved these changes Dec 11, 2023
View reviewed changes
Copy link

@blcham blcham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although i suggest to make it consistent ... if you started to call it phase, refactor all occurences of state

src/main/java/cz/cvut/kbss/study/model/PatientRecord.java Outdated Show resolved Hide resolved
@LaChope
Copy link
Collaborator

LaChope commented Dec 11, 2023

@blcham
There are still issues, when posting the "phase" to backend, it does not return it and do not save it to database, see below:

image

image

@blcham
Copy link

blcham commented Dec 11, 2023

@LaChope try to search "state" instead "phase" ... because @kostobog did not refactor actual RDF model behind it

@LaChope
Copy link
Collaborator

LaChope commented Dec 11, 2023

@blcham No, it is not there neither

@kostobog kostobog mentioned this pull request Dec 12, 2023
Closed
@blcham
Copy link

blcham commented Dec 12, 2023

@kostobog in what state is this PR?

@LaChope
Copy link
Collaborator

LaChope commented Dec 13, 2023

Everything works now, LGTM

@kostobog kostobog mentioned this pull request Dec 13, 2023
Merged
@blcham blcham merged commit c0f1a7e into main Dec 13, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LaChope LaChope LaChope approved these changes

@blcham blcham blcham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kostobog @LaChope @blcham