Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Created Procedure for Setting Up a Scaler #1415

Closed
wants to merge 39 commits into from
Closed

Created Procedure for Setting Up a Scaler #1415

wants to merge 39 commits into from

Conversation

shubhusion
Copy link
Contributor

Description of Changes

Created a procedure for setting up a scaler in KEDA.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Issue Fixed

Fixes kedacore/keda-docs#1368

@shubhusion shubhusion requested a review from a team as a code owner June 28, 2024 08:22
@github-actions GitHub Actions
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

@netlify Netlify
Copy link

netlify bot commented Jun 28, 2024 •
edited
Loading

✅ Deploy Preview for keda ready!

Name Link
🔨 Latest commit 965a94e
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/66b0fe6bc8e2c200083ffd54
😎 Deploy Preview https://deploy-preview-1415--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shubhusion
Copy link
Contributor Author

@tomkerkhove please review this issue

@shubhusion shubhusion mentioned this pull request Jun 28, 2024
Open
@shubhusion
Copy link
Contributor Author

@zroubalik can you please review

@JorTurFer
Copy link
Member

I love the idea of adding this PR ❤️

@shubhusion
Copy link
Contributor Author

@JorTurFer @zroubalik I have added a Note for HTTP Add-on.

zroubalik
zroubalik reviewed Aug 5, 2024
View reviewed changes
content/docs/2.14/operate/setupscaler.md Outdated Show resolved Hide resolved
content/docs/2.15/operate/setupscaler.md Show resolved Hide resolved
content/docs/2.14/operate/setupscaler.md Outdated Show resolved Hide resolved
content/docs/2.15/operate/setupscaler.md Show resolved Hide resolved
content/docs/2.15/operate/setupscaler.md Show resolved Hide resolved
content/docs/2.14/operate/setupscaler.md Outdated Show resolved Hide resolved
zroubalik
zroubalik reviewed Aug 5, 2024
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should move this into Getting Started section: https://keda.sh/docs/2.15/

At least for 2.15

shubhusion and others added 6 commits August 5, 2024 19:11
@shubhusion @zroubalik
Update content/docs/2.14/operate/setupscaler.md
68f0a47 
Co-authored-by: Zbynek Roubalik <[email protected]>
Signed-off-by: SHUBHAM SHARMA  <[email protected]>
@shubhusion @zroubalik
Update content/docs/2.14/operate/setupscaler.md
98cda61 
Co-authored-by: Zbynek Roubalik <[email protected]>
Signed-off-by: SHUBHAM SHARMA  <[email protected]>
@shubhusion @zroubalik
Update content/docs/2.15/operate/setupscaler.md
2909cf4 
Co-authored-by: Zbynek Roubalik <[email protected]>
Signed-off-by: SHUBHAM SHARMA  <[email protected]>
@shubhusion @zroubalik
Update content/docs/2.15/operate/setupscaler.md
1b843b3 
Co-authored-by: Zbynek Roubalik <[email protected]>
Signed-off-by: SHUBHAM SHARMA  <[email protected]>
@shubhusion @zroubalik
Update content/docs/2.14/operate/setupscaler.md
e941483 
Co-authored-by: Zbynek Roubalik <[email protected]>
Signed-off-by: SHUBHAM SHARMA  <[email protected]>
@shubhusion
Merge branch 'main' into shubhusion
2e4252d
@shubhusion
Copy link
Contributor Author

I think we should move this into Getting Started section: https://keda.sh/docs/2.15/

At least for 2.15

Thanks for the review. I will make the necessary changes as specified.

dwelsch-esi and others added 24 commits August 5, 2024 21:56
@dwelsch-esi @tomkerkhove
@nate-double-u @thisisobate @shubhusion
Added Reference section, Glossary, removed non-inclusive language. (k…
eba4f53 
…edacore#1389)

Co-authored-by: Dave Welsch <[email protected]>
Co-authored-by: Tom Kerkhove <[email protected]>
Co-authored-by: Nate W <[email protected]>
Co-authored-by: thisisobate <[email protected]>
Signed-off-by: shubhusion <[email protected]>
@shubhusion
Added a Note
8f8bb08 
Signed-off-by: shubhusion <[email protected]>
@rxg8255 @shubhusion
Add support for cassandra tls under v2.15 (kedacore#1390)
fc9e3a0 
Signed-off-by: Ranjith Gopal <[email protected]>
Co-authored-by: Ranjith Gopal <[email protected]>
Signed-off-by: shubhusion <[email protected]>
@circa10a @shubhusion
feat: splunk scaler docs (kedacore#1413)
0927db2 
Signed-off-by: shubhusion <[email protected]>
@thisisobate @shubhusion
Feat: version faq docs (kedacore#1416)
704e541 
Signed-off-by: shubhusion <[email protected]>
@zroubalik @shubhusion
Update Kedify link (kedacore#1421)
ddd894d 
Signed-off-by: Zbynek Roubalik <[email protected]>
Signed-off-by: shubhusion <[email protected]>
@tomkerkhove @shubhusion
fix: Align Kedify links (kedacore#1422)
7f49ce0 
Signed-off-by: Tom Kerkhove <[email protected]>
Signed-off-by: shubhusion <[email protected]>
@thisisobate @shubhusion
chore: fix faq version dropdown in older versions (kedacore#1423)
eedd10e 
Signed-off-by: shubhusion <[email protected]>
@SpiritZhou @shubhusion
Update (kedacore#1420)
cabfc59 
Signed-off-by: SpiritZhou <[email protected]>
Signed-off-by: shubhusion <[email protected]>
@zroubalik @shubhusion
Add lightweight Scarf analytics pixel to thewebsite (kedacore#1426)
c868e70 
Signed-off-by: shubhusion <[email protected]>
@zroubalik @shubhusion
put tracking pixel into correct location (kedacore#1427)
4c84e5e 
Signed-off-by: Zbynek Roubalik <[email protected]>
Signed-off-by: shubhusion <[email protected]>
@zroubalik @shubhusion
navbar + hero refactor (kedacore#1428)
4080c91 
Signed-off-by: shubhusion <[email protected]>
@Indresh2410 @shubhusion
Mysql scaler username from env (kedacore#1419)
a8bb32f 
* Add usernameFromEnv support for MYSQL Scaler

Signed-off-by: Indresh2410 <[email protected]>

* Fix typo

Signed-off-by: Indresh2410 <[email protected]>

* Update Readme

Signed-off-by: Indresh2410 <[email protected]>

* Move readme to different folder

Signed-off-by: Indresh2410 <[email protected]>

---------

Signed-off-by: Indresh2410 <[email protected]>
Signed-off-by: shubhusion <[email protected]>
@rickbrouwer @shubhusion
feat: update IBM MQ scaler docs for TLS support (kedacore#1433)
785fe4e 
Signed-off-by: rickbrouwer <[email protected]>
Signed-off-by: shubhusion <[email protected]>
@Caislear @shubhusion
feat: add GCP Pub/Sub new optional valueIfNull trigger configuration (k…
95d3a31 
…edacore#1410)

Signed-off-by: Benjamin Woodley <[email protected]>
Signed-off-by: shubhusion <[email protected]>
@Ferdinanddb @shubhusion
Update postgres scaler doc for aad (kedacore#1437)
fe0e494 
* Update postgres scaler doc to include info about Azure access token auth

Signed-off-by: Ferdinand de Baecque <[email protected]>

* minor changes to respect conventions

Signed-off-by: Ferdinand de Baecque <[email protected]>

---------

Signed-off-by: Ferdinand de Baecque <[email protected]>
Signed-off-by: shubhusion <[email protected]>
@arapulido @shubhusion
Add Datadog scaler docs for the new option to use the Cluster Agent a…
e6e63dd 
…s proxy (kedacore#1310)

* Add docs for Datadog scaler with Cluster Agent

Signed-off-by: Ara Pulido <[email protected]>

* Add optional parameters for the Cluster Agent API server

Signed-off-by: Ara Pulido <[email protected]>

* Move new DD docs to 2.14

Signed-off-by: Ara Pulido <[email protected]>

* Add missing cluster agent option

Signed-off-by: Ara Pulido <[email protected]>

* Add option in the cluster agent to avoid autogenerating DatadogMetric objects

Signed-off-by: Ara Pulido <[email protected]>

* fix typo in boolean string type

Signed-off-by: Ara Pulido <[email protected]>

* Move Datadog cluster agent docs to 2.15 instead

Signed-off-by: Ara Pulido <[email protected]>

* Mark using the Cluster Agent as proxy as experimental

Signed-off-by: Ara Pulido <[email protected]>

* datadogMetricsService paramter is mandatory

Signed-off-by: Ara Pulido <[email protected]>

* Establish 1.8.0 as the minimum version of the Datadog Operator required for this

Signed-off-by: Ara Pulido <[email protected]>

---------

Signed-off-by: Ara Pulido <[email protected]>
Signed-off-by: shubhusion <[email protected]>
@leodip @shubhusion
Add queueLengthStrategy option to azure-storage-queue scaler. (kedaco…
2a3835c 
…re#1406)

Signed-off-by: Leonardo D'Ippolito <[email protected]>
Signed-off-by: shubhusion <[email protected]>
@zroubalik @shubhusion
add explanation fore eager scaling strategy (kedacore#1438)
b9dedbe 
Signed-off-by: Zbynek Roubalik <[email protected]>
Signed-off-by: shubhusion <[email protected]>
@n3wt0n @shubhusion
Added Playstudios as listed user (kedacore#1436)
824c5d3 
Signed-off-by: Davide Benvegnu <[email protected]>
Signed-off-by: Davide Benvegnù aka CoderDave <[email protected]>
Signed-off-by: shubhusion <[email protected]>
@pauldotyu @shubhusion
Adding a note about Prometheus metrics being emitted scalers are depl…
b751c5d 
…oyed (kedacore#1425)

Signed-off-by: Paul Yu <[email protected]>
Signed-off-by: shubhusion <[email protected]>
@1it @shubhusion
add: Istio operation doc (kedacore#1418)
a618868 
Signed-off-by: ivan.tuzhilkin <[email protected]>
Signed-off-by: shubhusion <[email protected]>
@zroubalik @shubhusion
fix: initialCooldownPeriod is missing in the SO Spec example (kedac…
34b0e4e 
…ore#1411)

Signed-off-by: Zbynek Roubalik <[email protected]>
Signed-off-by: shubhusion <[email protected]>
@shubhusion
Merge branch 'shubhusion' of https://github.com/shubhusion/keda-docs …
965a94e 
…into shubhusion
@shubhusion
Copy link
Contributor Author

shubhusion commented Aug 5, 2024 •
edited
Loading

@JorTurFer I guess I made a mistake while rebasing. I have created a new PR with the required changed. Please review that
PR: #1446

@shubhusion shubhusion closed this Aug 5, 2024
@shubhusion shubhusion mentioned this pull request Aug 5, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik left review comments

@JorTurFer JorTurFer Awaiting requested review from JorTurFer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Write a Procedure for Setting Up a Scaler