Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor cron scaler config #6098

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Refactor cron scaler config #6098

merged 1 commit into from
Aug 28, 2024

Conversation

rickbrouwer
Copy link
Contributor

@rickbrouwer rickbrouwer commented Aug 22, 2024 •
edited
Loading

  • Refactor the scaler to match the new metadata guidelines.

Checklist

Related: 5797

@rickbrouwer rickbrouwer requested a review from a team as a code owner August 22, 2024 08:31
@rickbrouwer rickbrouwer marked this pull request as draft August 22, 2024 08:32
semgrep-app[bot]
semgrep-app bot reviewed Aug 22, 2024
View reviewed changes
pkg/scalers/cron_scaler.go Outdated Show resolved Hide resolved
@rickbrouwer rickbrouwer changed the title WIP: Refactor cron scaler config Refactor cron scaler config Aug 22, 2024
@rickbrouwer rickbrouwer marked this pull request as ready for review August 22, 2024 10:58
@rickbrouwer
Copy link
Contributor Author

Hi @wozniakjan

I've also refactored the cron scaler to match the new metadata guidelines. Can you please take a quick look at the code to make sure that it's matches the new metadata guidelines? 🙏

@rickbrouwer
Refactor cron scaler config
1d6c6af 
Signed-off-by: Rick Brouwer <[email protected]>
wozniakjan
wozniakjan approved these changes Aug 22, 2024
View reviewed changes
Copy link
Member

@wozniakjan wozniakjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, this is perfect!

Thank you so much @rickbrouwer ❤️

@wozniakjan
Copy link
Member

wozniakjan commented Aug 22, 2024 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progress here

@rickbrouwer
Copy link
Contributor Author

@wozniakjan I think only the run-e2e for cron must run, but maybe I'm wrong

@wozniakjan
Copy link
Member

@wozniakjan I think only the run-e2e for cron must run, but maybe I'm wrong

you are right, thanks for reminding me :)

@wozniakjan
Copy link
Member

wozniakjan commented Aug 23, 2024 •
edited by github-actions bot
Loading

/run-e2e cron
Update: You can check the progress here

@wozniakjan
Copy link
Member

I think this is ok to merge, ptal @kedacore/keda-contributors

@rickbrouwer rickbrouwer mentioned this pull request Aug 23, 2024
Closed
3 tasks
@JorTurFer JorTurFer merged commit e4491dd into kedacore:main Aug 28, 2024
20 checks passed
@dovics dovics mentioned this pull request Sep 30, 2024
Merged
4 tasks
JorTurFer pushed a commit to JorTurFer/keda that referenced this pull request Oct 7, 2024
@rickbrouwer @JorTurFer
Refactor cron scaler config (kedacore#6098)
10942a9 
Signed-off-by: Rick Brouwer <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>
@wozniakjan wozniakjan mentioned this pull request Oct 21, 2024
Open
59 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@semgrep-app semgrep-app[bot] semgrep-app[bot] left review comments

@JorTurFer JorTurFer JorTurFer approved these changes

@wozniakjan wozniakjan wozniakjan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rickbrouwer @wozniakjan @JorTurFer