Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor CPU/Memory scaler config #6229

Merged
merged 2 commits into from
Oct 16, 2024
Merged

Refactor CPU/Memory scaler config #6229

merged 2 commits into from
Oct 16, 2024

Conversation

rickbrouwer
Copy link
Contributor

@rickbrouwer rickbrouwer commented Oct 10, 2024

  • Refactor the scaler to match the new metadata guidelines.
  • The parameter type is already from release 2.7 deprecated. I think it's time to announce the removal and remove the deprecated code in version 2.18.

Checklist

Related: 5797
Docs: kedacore/keda-docs#1484

@rickbrouwer rickbrouwer requested a review from a team as a code owner October 10, 2024 15:15
@rickbrouwer rickbrouwer marked this pull request as draft October 10, 2024 15:16
@rickbrouwer rickbrouwer force-pushed the cpu branch 10 times, most recently from 6fc57a9 to eda726e Compare October 11, 2024 09:13
@rickbrouwer rickbrouwer changed the title Refactor Cpu memory scaler config Refactor CPU/Memory scaler config Oct 11, 2024
Signed-off-by: rickbrouwer <[email protected]>
Copy link
Member

@wozniakjan wozniakjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you!

@wozniakjan
Copy link
Member

/run-e2e

@rickbrouwer
Copy link
Contributor Author

/run-e2e

Hi @wozniakjan. It seems that the e2e run does not start, or takes a bit longer than normal. That is also possible. Or should an extra parameter be given so that it does start?

@wozniakjan
Copy link
Member

looks like the github actions runner has a hard time - https://github.com/kedacore/keda/actions/runs/11320727466/job/31478704705

Job is waiting for a runner from 'equinix-2cpu-8gb' to come online.

I will check in with others to see what happened

@wozniakjan
Copy link
Member

#6238 - we had to revert the CNCF runners, e2e tests should now be back

@wozniakjan
Copy link
Member

wozniakjan commented Oct 15, 2024

/run-e2e cpu
Update: You can check the progress here

Signed-off-by: rickbrouwer <[email protected]>
@JorTurFer
Copy link
Member

JorTurFer commented Oct 16, 2024

/run-e2e cpu
Update: You can check the progress here

@JorTurFer JorTurFer enabled auto-merge (squash) October 16, 2024 18:10
@JorTurFer JorTurFer merged commit 00f4e51 into kedacore:main Oct 16, 2024
19 checks passed
rickbrouwer added a commit to rickbrouwer/keda that referenced this pull request Oct 21, 2024
* Refactor cpu memory scaler

Signed-off-by: rickbrouwer <[email protected]>

* Fix

Signed-off-by: rickbrouwer <[email protected]>

---------

Signed-off-by: rickbrouwer <[email protected]>
@rickbrouwer rickbrouwer deleted the cpu branch October 21, 2024 12:52
mpechner-akasa pushed a commit to nrichardson-akasa/keda that referenced this pull request Nov 29, 2024
* Refactor cpu memory scaler

Signed-off-by: rickbrouwer <[email protected]>

* Fix

Signed-off-by: rickbrouwer <[email protected]>

---------

Signed-off-by: rickbrouwer <[email protected]>
Signed-off-by: michael pechner <[email protected]>
chiragbhatia8 pushed a commit to chiragbhatia8/keda that referenced this pull request Jan 9, 2025
* Refactor cpu memory scaler

Signed-off-by: rickbrouwer <[email protected]>

* Fix

Signed-off-by: rickbrouwer <[email protected]>

---------

Signed-off-by: rickbrouwer <[email protected]>
Signed-off-by: Chirag Bhatia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants