-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor CPU/Memory scaler config #6229
Conversation
6fc57a9
to
eda726e
Compare
Signed-off-by: rickbrouwer <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thank you!
/run-e2e |
Hi @wozniakjan. It seems that the e2e run does not start, or takes a bit longer than normal. That is also possible. Or should an extra parameter be given so that it does start? |
looks like the github actions runner has a hard time - https://github.com/kedacore/keda/actions/runs/11320727466/job/31478704705
I will check in with others to see what happened |
#6238 - we had to revert the CNCF runners, e2e tests should now be back |
/run-e2e cpu |
Signed-off-by: rickbrouwer <[email protected]>
/run-e2e cpu |
* Refactor cpu memory scaler Signed-off-by: rickbrouwer <[email protected]> * Fix Signed-off-by: rickbrouwer <[email protected]> --------- Signed-off-by: rickbrouwer <[email protected]>
* Refactor cpu memory scaler Signed-off-by: rickbrouwer <[email protected]> * Fix Signed-off-by: rickbrouwer <[email protected]> --------- Signed-off-by: rickbrouwer <[email protected]> Signed-off-by: michael pechner <[email protected]>
* Refactor cpu memory scaler Signed-off-by: rickbrouwer <[email protected]> * Fix Signed-off-by: rickbrouwer <[email protected]> --------- Signed-off-by: rickbrouwer <[email protected]> Signed-off-by: Chirag Bhatia <[email protected]>
type
is already from release 2.7 deprecated. I think it's time to announce the removal and remove the deprecated code in version 2.18.Checklist
Related: 5797
Docs: kedacore/keda-docs#1484