Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor New Relic scaler #6326

Merged
merged 1 commit into from
Nov 11, 2024

Refactor New Relic scaler

c4e39d8
Select commit
Loading
Failed to load commit list.
Merged

Refactor New Relic scaler #6326

Refactor New Relic scaler
c4e39d8
Select commit
Loading
Failed to load commit list.
Task list completed / task-list-completed succeeded Nov 11, 2024 in 0s

3 / 3 tasks completed

All tasks have been completed

Details

Required Tasks

Task Status
Refactor the scaler to match the new metadata guidelines. Incomplete
The New Relic test showed that "0" and "1" are also valid values ​​for a boolean, but TypedConfig only accepts "true" and "false". Therefore, in the setConfigValueHelper, the function of typed_config.go has been adjusted for boolean parsing. Incomplete
I have verified that my change is according to the deprecations & breaking changes policy Completed
Tests have been added Completed
Commits are signed with Developer Certificate of Origin (DCO - learn more) Completed