Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize deposit sweeping #3802

Closed
3 tasks done
lukasz-zimnoch opened this issue Apr 11, 2024 · 0 comments · Fixed by #3805
Closed
3 tasks done

Optimize deposit sweeping #3802

lukasz-zimnoch opened this issue Apr 11, 2024 · 0 comments · Fixed by #3805
Assignees
@lukasz-zimnoch
Labels
📟 client
Milestone
v2.0.1

Comments

@lukasz-zimnoch
Copy link
Member

lukasz-zimnoch commented Apr 11, 2024 •
edited
Loading

The tBTC system observes an increase in the deposit count. The current configuration of the deposit sweep process experiences congestion and the time-to-sweep of a single deposit is extended to far more than the expected 48 hours. Although this is not a critical problem due to a long refund time, we need to optimize the deposit sweep process and make it able to handle significant deposit numbers gracefully.

Tasks
Beta Give feedback
  1. Increase deposit sweep frequency #3803
    📟 client
    lukasz-zimnoch
  2. Retry upon coordination proposal failure #3804
    📟 client
    lukasz-zimnoch
  3. Optimize deposit sweep proposal generator #3805
    📟 client
    lukasz-zimnoch
@lukasz-zimnoch lukasz-zimnoch self-assigned this Apr 11, 2024
@lukasz-zimnoch lukasz-zimnoch mentioned this issue Apr 11, 2024
Merged
@lukasz-zimnoch lukasz-zimnoch added this to the v2.0.1 milestone Apr 11, 2024
tomaszslabon added a commit that referenced this issue Apr 11, 2024
@tomaszslabon
Increase deposit sweep frequency (#3803)
c135a53 
Refs: #3802

So far, deposit sweeps were supposed to happen every 48 hours. This
frequency was good for the early days of the system but starts to be
insufficient now, when a significant number of deposits land every day.
To optimize the deposit sweep process, we are increasing its frequency
to 12 hours.
@lukasz-zimnoch lukasz-zimnoch mentioned this issue Apr 11, 2024
Merged
tomaszslabon added a commit that referenced this issue Apr 11, 2024
@tomaszslabon
Retry upon coordination proposal failure (#3804)
24e149f 
Refs: #3802

Here we attempt to harden proposal generation by retrying the process in
case of failure. Proposal generation strongly relies on 3rd party
services like Ethereum RPC and Electrum servers. Temporary disruption of
those services can easily nuke proposal generation and cause a
coordination window miss. Retrying proposal generation after a short
delay should help overcome temporary problems and increase success
chance of coordination windows.
@lukasz-zimnoch lukasz-zimnoch mentioned this issue Apr 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukasz-zimnoch lukasz-zimnoch

Labels
📟 client
Projects
None yet
Milestone
v2.0.1
Development

Successfully merging a pull request may close this issue.

Optimize deposit sweep proposal generator keep-network/keep-core
1 participant
@lukasz-zimnoch