Optimize deposit sweep proposal generator #3805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fetching deposit script type is not needed for sweep proposal generation. Doing so means making an additional Electrum call for each deposit. This makes proposal generation longer and more prone to failure. At the same time, the script type is used only for Maintainer CLI which is not so important since we have tbtcscan and there is no way to manually trigger sweeps due to the introduction of RFC 12. That said, we are removing script type fetch from the process.
tomaszslabon
approved these changes
Apr 11, 2024
lukasz-zimnoch
added a commit
that referenced
this pull request
Apr 11, 2024
This pull request backports #3805 to the `releases/mainnet/v2.0.1` branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #3802
Fetching deposit script type is not needed for sweep proposal generation. Doing so means making an additional Electrum call for each deposit. This makes proposal generation longer and more prone to failure.
At the same time, the script type is used only for Maintainer CLI which is not so important since we have tbtcscan and there is no way to manually trigger sweeps due to the introduction of RFC 12.
That said, we are removing script type fetch from the process.