Retry upon coordination proposal failure #3804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here we attempt to harden proposal generation by retrying the process in case of failure. Proposal generation strongly relies on 3rd party services like Ethereum RPC and Electrum servers. Temporary disruption of those services can easily nuke proposal generation and cause a coordination window miss. Retrying proposal generation after a short delay should help overcome temporary problems and increase success chance of coordination windows.
tomaszslabon
approved these changes
Apr 11, 2024
lukasz-zimnoch
added a commit
that referenced
this pull request
Apr 11, 2024
This pull request backports #3804 to the `releases/mainnet/v2.0.1` branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #3802
Here we attempt to harden proposal generation by retrying the process in case of failure. Proposal generation strongly relies on 3rd party services like Ethereum RPC and Electrum servers. Temporary disruption of those services can easily nuke proposal generation and cause a coordination window miss. Retrying proposal generation after a short delay should help overcome temporary problems and increase success chance of coordination windows.