Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: impl validate BIP-34 sig script #135

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

od-hunter
Copy link
Contributor

  • issue #
  • follows contribution guide
  • code change includes tests

Copy link

vercel bot commented Sep 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
raito ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 6, 2024 9:26pm

@od-hunter
Copy link
Contributor Author

@maciejka @m-kus Kindly review.

src/validation/coinbase.cairo Show resolved Hide resolved
src/validation/coinbase.cairo Outdated Show resolved Hide resolved
@od-hunter
Copy link
Contributor Author

@maciejka all requested changes have been implemented, kindly review.

@od-hunter
Copy link
Contributor Author

@maciejka kindly review, this has been a tough one wow!

@od-hunter od-hunter requested a review from maciejka September 5, 2024 01:55
src/validation/coinbase.cairo Outdated Show resolved Hide resolved
@od-hunter
Copy link
Contributor Author

od-hunter commented Sep 5, 2024

@maciejka @m-kus , Kindly review.

Copy link
Collaborator

@maciejka maciejka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @m-kus?

src/validation/coinbase.cairo Outdated Show resolved Hide resolved
src/validation/coinbase.cairo Outdated Show resolved Hide resolved
@od-hunter
Copy link
Contributor Author

@m-kus Kindly review

src/validation/coinbase.cairo Outdated Show resolved Hide resolved
@od-hunter
Copy link
Contributor Author

@m-kus Kindly review

@od-hunter od-hunter requested a review from m-kus September 6, 2024 04:54
Copy link
Collaborator

@maciejka maciejka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/validation/coinbase.cairo Outdated Show resolved Hide resolved
@od-hunter
Copy link
Contributor Author

@m-kus review.

@m-kus
Copy link
Collaborator

m-kus commented Sep 6, 2024

Please rebase (first squash commits locally to avoid too much conflicts, then rebase).
Just a reminder

git rebase -i HEAD~9 (keep the first line, change to "s" all subsequent)
git push origin <your branch> --force
git checkout main (sync your fork first)
git pull
git checkout <your branch>
git rebase main
git push origin <your branch> --force

@od-hunter
Copy link
Contributor Author

Hello @m-kus the rebased changes from this instruction is breaking the code, especially from the transaction.cairo file. Kindly check.

Please rebase (first squash commits locally to avoid too much conflicts, then rebase). Just a reminder

git rebase -i HEAD~9 (keep the first line, change to "s" all subsequent)
git push origin <your branch> --force
git checkout main (sync your fork first)
git pull
git checkout <your branch>
git rebase main
git push origin <your branch> --force

@m-kus
Copy link
Collaborator

m-kus commented Sep 6, 2024

d5d7daa#diff-56d055243928a694ab0740cda0bee2abe8f4d48a7921ce014174e274cc1dc14aR7 looks like you haven't resolved conflicts and your rebase is not finished.

@od-hunter
Copy link
Contributor Author

@m-kus you can review and merge now.

@m-kus m-kus merged commit 8edb649 into keep-starknet-strange:main Sep 6, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants