-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: impl validate BIP-34 sig script #135
Conversation
od-hunter
commented
Sep 3, 2024
- issue #
- follows contribution guide
- code change includes tests
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@maciejka all requested changes have been implemented, kindly review. |
@maciejka kindly review, this has been a tough one wow! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, @m-kus?
@m-kus Kindly review |
@m-kus Kindly review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@m-kus review. |
Please rebase (first squash commits locally to avoid too much conflicts, then rebase).
|
Hello @m-kus the rebased changes from this instruction is breaking the code, especially from the
|
d5d7daa#diff-56d055243928a694ab0740cda0bee2abe8f4d48a7921ce014174e274cc1dc14aR7 looks like you haven't resolved conflicts and your rebase is not finished. |
@m-kus you can review and merge now. |