Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improvements in helm chart #18

Merged
merged 4 commits into from
Apr 3, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/keep/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
apiVersion: v2
name: keep
version: 0.0.4
version: 0.0.5
description: Keep Helm Chart
type: application
icon: https://platform.keephq.dev/_next/image?url=%2Fkeep.png&w=48&q=75
Expand Down
34 changes: 31 additions & 3 deletions charts/keep/README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# keep

![Version: 0.0.4](https://img.shields.io/badge/Version-0.0.4-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 0.2.1](https://img.shields.io/badge/AppVersion-0.2.1-informational?style=flat-square)
![Version: 0.0.5](https://img.shields.io/badge/Version-0.0.5-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 0.2.1](https://img.shields.io/badge/AppVersion-0.2.1-informational?style=flat-square)

Keep Helm Chart

Expand Down Expand Up @@ -48,6 +48,13 @@ Keep Helm Chart
| backend.env[7].value | string | `"keep-websocket"` | |
| backend.env[8].name | string | `"PUSHER_PORT"` | |
| backend.env[8].value | int | `6001` | |
| backend.extraVolumeMounts | list | `[]` | |
| backend.extraVolumes | list | `[]` | |
| backend.healthCheck.enabled | bool | `false` | |
| backend.healthCheck.probes.livenessProbe.tcpSocket.port | int | `8080` | |
| backend.healthCheck.probes.readinessProbe.initialDelaySeconds | int | `30` | |
| backend.healthCheck.probes.readinessProbe.periodSeconds | int | `10` | |
| backend.healthCheck.probes.readinessProbe.tcpSocket.port | int | `8080` | |
| backend.image.pullPolicy | string | `"Always"` | |
| backend.image.repository | string | `"us-central1-docker.pkg.dev/keephq/keep/keep-api"` | |
| backend.image.tag | string | `"latest"` | |
Expand Down Expand Up @@ -85,20 +92,31 @@ Keep Helm Chart
| database.env[1].value | string | `"keep"` | |
| database.env[2].name | string | `"MYSQL_PASSWORD"` | |
| database.env[2].value | string | `nil` | |
| database.extraVolumeMounts | list | `[]` | |
| database.extraVolumes | list | `[]` | |
| database.healthCheck.enabled | bool | `false` | |
| database.healthCheck.probes.livenessProbe.tcpSocket.port | int | `3306` | |
| database.healthCheck.probes.readinessProbe.initialDelaySeconds | int | `30` | |
| database.healthCheck.probes.readinessProbe.periodSeconds | int | `10` | |
| database.healthCheck.probes.readinessProbe.tcpSocket.port | int | `3306` | |
| database.image.pullPolicy | string | `"IfNotPresent"` | |
| database.image.repository | string | `"mysql"` | |
| database.image.tag | string | `"latest"` | |
| database.imagePullSecrets | list | `[]` | |
| database.nodeSelector | object | `{}` | |
| database.podAnnotations | object | `{}` | |
| database.podSecurityContext | object | `{}` | |
| database.pv.enabled | bool | `true` | |
| database.pv.size | string | `"5Gi"` | |
| database.pv.storageClass | string | `""` | |
| database.pvc.enabled | bool | `true` | |
| database.pvc.size | string | `"5Gi"` | |
| database.pvc.storageClass | string | `""` | |
| database.replicaCount | int | `1` | |
| database.resources | object | `{}` | |
| database.securityContext | object | `{}` | |
| database.service.port | int | `3306` | |
| database.service.type | string | `"ClusterIP"` | |
| database.size | string | `"5Gi"` | |
| database.storageClass | string | `""` | |
| database.tolerations | list | `[]` | |
| frontend.affinity | object | `{}` | |
| frontend.autoscaling.enabled | bool | `false` | |
Expand Down Expand Up @@ -130,6 +148,11 @@ Keep Helm Chart
| frontend.env[8].value | string | `"0.0.0.0"` | |
| frontend.env[9].name | string | `"PUSHER_HOST"` | |
| frontend.env[9].value | string | `"keep-websocket.default.svc.cluster.local"` | |
| frontend.healthCheck.enabled | bool | `false` | |
| frontend.healthCheck.probes.livenessProbe.httpGet.path | string | `"/"` | |
| frontend.healthCheck.probes.livenessProbe.httpGet.port | string | `"http"` | |
| frontend.healthCheck.probes.readinessProbe.httpGet.path | string | `"/"` | |
| frontend.healthCheck.probes.readinessProbe.httpGet.port | string | `"http"` | |
| frontend.image.pullPolicy | string | `"Always"` | |
| frontend.image.repository | string | `"us-central1-docker.pkg.dev/keephq/keep/keep-ui"` | |
| frontend.image.tag | string | `"latest"` | |
Expand Down Expand Up @@ -178,6 +201,11 @@ Keep Helm Chart
| websocket.env[2].value | string | `"keepappkey"` | |
| websocket.env[3].name | string | `"SOKETI_DEFAULT_APP_SECRET"` | |
| websocket.env[3].value | string | `"keepappsecret"` | |
| websocket.healthCheck.enabled | bool | `false` | |
| websocket.healthCheck.probes.livenessProbe.httpGet.path | string | `"/"` | |
| websocket.healthCheck.probes.livenessProbe.httpGet.port | string | `"http"` | |
| websocket.healthCheck.probes.readinessProbe.httpGet.path | string | `"/"` | |
| websocket.healthCheck.probes.readinessProbe.httpGet.port | string | `"http"` | |
| websocket.image.pullPolicy | string | `"Always"` | |
| websocket.image.repository | string | `"quay.io/soketi/soketi:1.4-16-debian"` | |
| websocket.image.tag | string | `"latest"` | |
Expand Down
18 changes: 10 additions & 8 deletions charts/keep/templates/keep-backend.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -64,14 +64,13 @@ spec:
- name: state-volume
mountPath: /state
readOnly: false
# livenessProbe:
# httpGet:
# path: /
# port: http
# readinessProbe:
# httpGet:
# path: /
# port: http
{{- with .Values.backend.extraVolumeMounts }}
{{- toYaml . | nindent 12 }}
{{- end }}

{{- if .Values.backend.healthCheck.enabled }}
{{- toYaml .Values.backend.healthCheck.probes | nindent 10 }}
{{- end }}
resources:
{{- toYaml .Values.backend.resources | nindent 12 }}
initContainers:
Expand All @@ -96,4 +95,7 @@ spec:
volumes:
- name: state-volume
emptyDir: {}
{{- with .Values.backend.extraVolumes }}
{{- toYaml . | nindent 8 }}
{{- end }}
{{- end }}
6 changes: 3 additions & 3 deletions charts/keep/templates/keep-db-pv.yaml
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
{{- if .Values.database.enabled -}}
{{- if and .Values.database.enabled .Values.database.pv.enabled -}}
apiVersion: v1
kind: PersistentVolume
metadata:
name: {{ include "keep.fullname" . }}-pv
spec:
capacity:
storage: {{ .Values.database.size }}
storage: {{ .Values.database.pv.size }}
accessModes:
- ReadWriteOnce
persistentVolumeReclaimPolicy: Retain
storageClassName: {{ .Values.database.storageClass }}
storageClassName: {{ .Values.database.pv.storageClass }}
hostPath:
path: "/var/lib/mysql"
{{- end }}
6 changes: 3 additions & 3 deletions charts/keep/templates/keep-db-pvc.yaml
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
{{- if .Values.database.enabled -}}
{{- if and .Values.database.enabled .Values.database.pvc.enabled -}}
apiVersion: v1
kind: PersistentVolumeClaim
metadata:
name: {{ include "keep.fullname" . }}-pvc
spec:
accessModes:
- ReadWriteOnce
storageClassName: {{ .Values.database.storageClass }}
storageClassName: {{ .Values.database.pvc.storageClass }}
resources:
requests:
storage: 5Gi
storage: {{ .Values.database.pvc.size }}
{{- end }}
9 changes: 9 additions & 0 deletions charts/keep/templates/keep-db.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,12 @@ spec:
- mountPath: /var/lib/mysql
name: {{ include "keep.fullname" . }}-pv
readOnly: false
{{- with .Values.database.extraVolumeMounts }}
{{- toYaml . | nindent 10 }}
{{- end }}
{{- if .Values.database.healthCheck.enabled }}
{{- toYaml .Values.database.healthCheck.probes | nindent 10 }}
{{- end }}
resources:
{{- toYaml .Values.database.resources | nindent 12 }}
{{- with .Values.database.nodeSelector }}
Expand All @@ -67,4 +73,7 @@ spec:
- name: {{ include "keep.fullname" . }}-pv
persistentVolumeClaim:
claimName: {{ include "keep.fullname" . }}-pvc
{{- with .Values.database.extraVolumes }}
{{- toYaml . | nindent 8 }}
{{- end }}
{{- end }}
3 changes: 3 additions & 0 deletions charts/keep/templates/keep-frontend-service.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@ spec:
targetPort: http
protocol: TCP
name: http
{{ if eq .Values.frontend.service.type "NodePort" }}
nodePort: {{ .Values.frontend.service.nodePort }}
{{- end }}
selector:
{{- include "keep.selectorLabels" . | nindent 4 }}
keep-component: frontend
Expand Down
11 changes: 3 additions & 8 deletions charts/keep/templates/keep-frontend.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -49,14 +49,9 @@ spec:
- name: state-volume
mountPath: /state
readOnly: false
# livenessProbe:
# httpGet:
# path: /
# port: http
# readinessProbe:
# httpGet:
# path: /
# port: http
{{- if .Values.frontend.healthCheck.enabled }}
{{- toYaml .Values.frontend.healthCheck.probes | nindent 10 }}
{{- end }}
resources:
{{- toYaml .Values.frontend.resources | nindent 12 }}
{{- with .Values.frontend.nodeSelector }}
Expand Down
11 changes: 3 additions & 8 deletions charts/keep/templates/keep-websocket-server.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -49,14 +49,9 @@ spec:
- name: state-volume
mountPath: /state
readOnly: false
# livenessProbe:
# httpGet:
# path: /
# port: http
# readinessProbe:
# httpGet:
# path: /
# port: http
{{- if .Values.websocket.healthCheck.enabled }}
{{- toYaml .Values.websocket.healthCheck.probes | nindent 10 }}
{{- end }}
resources:
{{- toYaml .Values.websocket.resources | nindent 12 }}
{{- with .Values.websocket.nodeSelector }}
Expand Down
58 changes: 56 additions & 2 deletions charts/keep/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,19 @@
nodeSelector: {}
tolerations: []
affinity: {}
healthCheck:
shahargl marked this conversation as resolved.
Show resolved Hide resolved
enabled: false
probes:
readinessProbe:
tcpSocket:
port: 8080
initialDelaySeconds: 30
periodSeconds: 10
livenessProbe:
tcpSocket:
port: 8080
extraVolumeMounts: []
extraVolumes: []

frontend:
enabled: true
Expand Down Expand Up @@ -145,6 +158,17 @@
nodeSelector: {}
tolerations: []
affinity: {}
healthCheck:
enabled: false
probes:
livenessProbe:
httpGet:
path: /
port: http
readinessProbe:
httpGet:
path: /
port: http

websocket:
enabled: true
Expand Down Expand Up @@ -182,19 +206,36 @@
nodeSelector: {}
tolerations: []
affinity: {}
healthCheck:
enabled: false
probes:
livenessProbe:
httpGet:
path: /
port: http
readinessProbe:
httpGet:
path: /
port: http

database:
enabled: true
replicaCount: 1
size: 5Gi
storageClass: ""
pv:
enabled: true
size: 5Gi
storageClass: ""
pvc:
enabled: true
size: 5Gi
storageClass: ""
image:
repository: mysql
pullPolicy: IfNotPresent
tag: "latest"
env:
- name: MYSQL_ALLOW_EMPTY_PASSWORD
value: yes

Check warning on line 238 in charts/keep/values.yaml

View workflow job for this annotation

GitHub Actions / lint-chart

238:14 [truthy] truthy value should be one of [false, true]
- name: MYSQL_DATABASE
value: keep
- name: MYSQL_PASSWORD
Expand All @@ -212,3 +253,16 @@
nodeSelector: {}
tolerations: []
affinity: {}
healthCheck:
enabled: false
probes:
readinessProbe:
tcpSocket:
port: 3306
initialDelaySeconds: 30
periodSeconds: 10
livenessProbe:
tcpSocket:
port: 3306
extraVolumeMounts: []
extraVolumes: []
Loading