Add functions of crosstalk neighbour finding

[zwu0922]

BEGINRELEASENOTES

• Add new functions related to the crosstalk neighbour finding for ALLEGRO ECAL barrel cells.

ENDRELEASENOTES

Added two more files "xtalk_k4geo.cpp" and "xtalk_k4geo.h". The new function in "xtalk_k4geo.cpp" can return the crosstalk neighbours and the corresponding crosstalk coefficients for a given cell of the ALLEGRO ECAL barrel with the theta-merged segmentation. No change is introduced to the existing part of the software package.

[andresailer]

Please nonetheless add something in BEGIN/ENDRELEASENOTES

[zwu0922]

Please nonetheless add something in BEGIN/ENDRELEASENOTES

The change has been specified between BEGIN/ENDRELEASENOTES.

[kjvbrt]

Local running of the test provided in HEP-FCC/k4RecCalorimeter#69 produced correct output file.

[BrieucF]

Since this is specific to the FCCSWGridModuleThetaMerged segmentation, I propose to go for less generic name, e.g. xtalk_k4geo --> xtalk_neighbors_moduleThetaMergedSegmentation or equivalent

[zwu0922]

Since this is specific to the FCCSWGridModuleThetaMerged segmentation, I propose to go for less generic name, e.g. xtalk_k4geo --> xtalk_neighbors_moduleThetaMergedSegmentation or equivalent

Names of two files have been changed:
xtalk_k4geo.cpp --> xtalk_neighbors_moduleThetaMergedSegmentation.cpp
xtalk_k4geo.h --> xtalk_neighbors_moduleThetaMergedSegmentation.h

[BrieucF]

Sorry to trigger on this so late, but why not including these two new functionalities in DetUtils_k4geo?

[zwu0922]

Sorry to trigger on this so late, but why not including these two new functionalities in DetUtils_k4geo?

Initially, I didn't want to change anything in the existing files for this development. However, it is true that including the two new functionalities in DetUtils_k4geo will not cause any conflict. Maybe I can merge "xtalk_neighbors_moduleThetaMergedSegmentation" into "DetUtils_k4geo" in the next round of development (to make the crosstalk coefficients configurable), if you don't object?

[BrieucF]

Initially, I didn't want to change anything in the existing files for this development. However, it is true that including the two new functionalities in DetUtils_k4geo will not cause any conflict. Maybe I can merge "xtalk_neighbors_moduleThetaMergedSegmentation" into "DetUtils_k4geo" in the next round of development (to make the crosstalk coefficients configurable), if you don't object?

Fine by me

[andresailer]

Hi @zwu0922
Thanks for your contribution, I have some proposals for changes.

• I would prefer if we use proper words, so crosstalk instead of xtalk in publicly visible interfaces.
• There is a namespace, so no need to prefix function names
• the whole point of emplace_back is that it forwards to the constructor, so we don't have to construct the object ourselves https://godbolt.org/z/E6h1nPPM4
• The list of includes could probably be cleaned up?
• Some improvements in the code

[zwu0922]

Hi @zwu0922 Thanks for your contribution, I have some proposals for changes.

* I would prefer if we use proper words, so crosstalk instead of xtalk in publicly visible interfaces.

* There is a namespace, so no need to prefix function names

* the whole point of emplace_back is that it forwards to the constructor, so we don't have to construct the object ourselves https://godbolt.org/z/E6h1nPPM4

* The list of includes could probably be cleaned up?

* Some improvements in the code

Thanks a lot for detailed suggestions. I have implemented all improvements and tested the code.

[andresailer]

Some clarifications for crosstalk coefficients.

[andresailer]

Thanks!