ISSUE#2 Fix deleting selectors when module disabled

kirchbergerknorr · Aug 2, 2020 · 1ec8b49 · 1ec8b49
1 parent d3bda5d
commit 1ec8b49
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 2 deletions.
diff --git a/src/Model/Config/Backend/Serialized/ArraySerialized.php b/src/Model/Config/Backend/Serialized/ArraySerialized.php
@@ -0,0 +1,26 @@
+<?php
+/**
+ * @author      Oleh Kravets <[email protected]>
+ * @copyright   Copyright (c) 2020 schoene neue kinder GmbH  (https://www.snk.de)
+ * @license     https://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+ */
+
+namespace Snk\Usercentrics\Model\Config\Backend\Serialized;
+
+class ArraySerialized extends \Magento\Config\Model\Config\Backend\Serialized\ArraySerialized
+{
+    /**
+     * Skip saving data if the module is not enabled
+     *
+     * @return ArraySerialized
+     */
+    public function beforeSave()
+    {
+        if (!$this->getFieldsetDataValue('enable')) {
+            $this->setData('value', $this->getOldValue());
+
+            return $this;
+        }
+        return parent::beforeSave();
+    }
+}
diff --git a/src/etc/adminhtml/system.xml b/src/etc/adminhtml/system.xml
@@ -33,9 +33,12 @@
                 <field id="selectors" translate="label" type="select" sortOrder="40" showInDefault="1" showInWebsite="1" showInStore="1" canRestore="1">
                     <label>Selectors</label>
                     <frontend_model>Snk\Usercentrics\Block\Adminhtml\System\Config\Form\Field\Selectors</frontend_model>
-                    <backend_model>Magento\Config\Model\Config\Backend\Serialized\ArraySerialized</backend_model>
+                    <backend_model>Snk\Usercentrics\Model\Config\Backend\Serialized\ArraySerialized</backend_model>
                     <depends><field id="enable">1</field></depends>
-                    <comment><![CDATA[Selectors for html being processed. For more details see <a href="#">documentation</a>.]]></comment>
+                    <comment><![CDATA[Selectors for html being processed. For more details see <a target="_blank"
+                        href="https://github.com/kirchbergerknorr/magento2-module-usercentrics#configuration-details">
+                        documentation on GitHub</a>.]]>
+                    </comment>
                 </field>
             </group>
         </section>