Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for mass import #5961

Merged
merged 2 commits into from
Mar 25, 2024
Merged

Conversation

solth
Copy link
Member

@solth solth commented Feb 27, 2024

This pull request adds unit, integration and Selenium tests for mass import.

Part of https://github.com/orgs/kitodo/projects/8

@solth solth force-pushed the mass-import-tests branch from f5b410e to a05cf9a Compare March 4, 2024 09:38
@BartChris
Copy link
Collaborator

BartChris commented Mar 25, 2024

Tests cover all existing functionality and look good to me.
One could maybe think of an integration tests doing a full test wether a uploaded CSV with two proceses actually creates those two processes. (the ImportService itself is already tested) But this could be added later.

Copy link
Member

@stweil stweil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My change request was implemented – thank you.

@solth solth merged commit c47d521 into kitodo:master Mar 25, 2024
5 checks passed
@solth solth deleted the mass-import-tests branch March 25, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

3 participants