Allow multiple values for same key in mass import csv #5998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BartChris may I ask why this pull request is a draft? Is something missing from it? |
|
I would like to add tests - if possible - after #5961 is merged. |
|
I see, very good point. Would you mind reviewing #5961 ? |
|
Yes, i will look into it. |
BartChris
force-pushed
the
mass_import_multi_value
branch
4 times, most recently
from
d142f5e to
b4e777f
Compare
solth
approved these changes
Apr 9, 2024
There was a problem hiding this comment.
@BartChris Thanks a lot! Functionality works as described and code looks good (save for some very small nitpicks). Could you also rebase branch against the current master before I merge this pull request?
Kitodo/src/test/java/org/kitodo/production/services/catalogimport/MassImportTest.java
Outdated
Show resolved
Hide resolved
Kitodo/src/test/java/org/kitodo/production/services/catalogimport/MassImportTest.java
Outdated
Show resolved
Hide resolved
Kitodo/src/test/java/org/kitodo/production/services/data/ImportServiceIT.java
Outdated
Show resolved
Hide resolved
Kitodo/src/test/java/org/kitodo/production/services/data/ImportServiceIT.java
Outdated
Show resolved
Hide resolved
Kitodo/src/test/java/org/kitodo/production/services/data/ImportServiceIT.java
Outdated
Show resolved
Hide resolved
BartChris
force-pushed
the
mass_import_multi_value
branch
from
b4e777f to
2a4b845
Compare
|
@BartChris thanks for implementing the change requests! Would you mind opening a corresponding pull request with the same fix against the 3.6.x branch (adjusted to the slightly different code base, if necessary)? |
|
@solth Yes, i will do it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5996