Configure httpRedirect on istio gateway in helm

[AyushSawant18588]

Fixes #
Update knative-serving CRD to allow configuring of HTTP->HTTPS redirection on Istio Gateway through helm chart. Currently through knative operator helm chart HTTP->HTTPS redirection on Istio Gateway is not configurable. This was done only in Knative operator manifest file in this PR: #1912

Issue: #1944

[linux-foundation-easycla]

• ✅login: AyushSawant18588 / (25c678e)

The committers listed above are authorized under a signed CLA.

[knative-prow]

Welcome @AyushSawant18588! It looks like this is your first PR to knative/operator 🎉

[knative-prow]

Hi @AyushSawant18588. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.88%. Comparing base (29e9f59) to head (25c678e).
Report is 3 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1948   +/-   ##
=======================================
  Coverage   63.88%   63.88%           
=======================================
  Files          54       54           
  Lines        2622     2622           
=======================================
  Hits         1675     1675           
  Misses        830      830           
  Partials      117      117           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[houshengbo]

@AyushSawant18588 could you join the knative org to pass the EasyCLA checking?

[houshengbo]

I am wondering whether you also need to change https://github.com/knative/operator/blob/main/config/charts/knative-operator/values.yaml for the default values of these new fields.

[AyushSawant18588]

These are changes in Knative Serving CRDs so I do not think there will be any change in values.yaml of knative-operator helm chart.
These changes will allow for httpRedirect configuration while creating Knative Serving Custom Resource after installing knative-operator through this helm chart. What do you think?

[houshengbo]

I thought you were about to configure the values for the fields added in this PR.
If they are not editable in values.yaml, they will always be the same values as defined in the CRD. Still not configurable.

[AyushSawant18588]

This PR introduces changes to enable applying the httpRedirect setting when creating Knative Serving after installing the Knative Operator using the Helm chart. Since this setting is for Knative Serving, this setting is not to be configurable through the values.yaml file of the Knative Operator Helm chart .

[houshengbo]

/test all

[houshengbo]

/lgtm
/approve

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AyushSawant18588, houshengbo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [houshengbo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment