Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure httpRedirect on istio gateway in helm #1948

Merged
merged 1 commit into from
Jan 2, 2025
Merged

Configure httpRedirect on istio gateway in helm #1948

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions config/charts/knative-operator/templates/operator.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4875,6 +4875,13 @@ spec:
type: string
type: object
tls:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am wondering whether you also need to change https://github.com/knative/operator/blob/main/config/charts/knative-operator/values.yaml for the default values of these new fields.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are changes in Knative Serving CRDs so I do not think there will be any change in values.yaml of knative-operator helm chart.
These changes will allow for httpRedirect configuration while creating Knative Serving Custom Resource after installing knative-operator through this helm chart. What do you think?

Copy link
Contributor

@houshengbo houshengbo Jan 2, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought you were about to configure the values for the fields added in this PR.
If they are not editable in values.yaml, they will always be the same values as defined in the CRD. Still not configurable.

Copy link
Contributor Author

@AyushSawant18588 AyushSawant18588 Jan 2, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR introduces changes to enable applying the httpRedirect setting when creating Knative Serving after installing the Knative Operator using the Helm chart. Since this setting is for Knative Serving, this setting is not to be configurable through the values.yaml file of the Knative Operator Helm chart .

nullable: true
oneOf:
- required:
- mode
- credentialName
- required:
- httpsRedirect
properties:
mode:
description: TLS mode can be SIMPLE, MUTUAL, ISTIO_MUTUAL.
Expand All @@ -4884,6 +4891,11 @@ spec:
description: TLS certificate name.
format: string
type: string
httpsRedirect:
description: If set to true, the load balancer will send a 301 redirect
to HTTPS for all HTTP requests. Should be used only for HTTP listener,
is mutually exclusive with all other TLS options.
type: boolean
type: object
type: object
type: array
Expand Down Expand Up @@ -4924,6 +4936,13 @@ spec:
type: string
type: object
tls:
nullable: true
oneOf:
- required:
- mode
- credentialName
- required:
- httpsRedirect
properties:
mode:
description: TLS mode can be SIMPLE, MUTUAL, ISTIO_MUTUAL.
Expand All @@ -4933,6 +4952,11 @@ spec:
description: TLS certificate name.
format: string
type: string
httpsRedirect:
description: If set to true, the load balancer will send a 301 redirect
to HTTPS for all HTTP requests. Should be used only for HTTP listener,
is mutually exclusive with all other TLS options.
type: boolean
type: object
type: object
type: array
Expand Down
Loading