Unset env.ValueFrom in ImageTransform #2016
Conversation
When there is an environment variable override for ImageTransform, there could be `ValueFrom` set, in which case the resulting environment field would have both `Value` and `ValueFrom` which is not valid.
knative-prow
bot
added
the
size/XS
|
/cherry-pick release-1.17 |
|
@pierDipi: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick release-1.16 |
|
@pierDipi: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matzew, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2016 +/- ##
==========================================
+ Coverage 62.76% 62.78% +0.01%
==========================================
Files 49 49
Lines 2291 2292 +1
==========================================
+ Hits 1438 1439 +1
Misses 761 761
Partials 92 92 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@pierDipi I just fixed the CI issue, could you rebase this PR? |
Updated the dependencies for 1.18 (knative#2015)
|
done |
|
/lgtm |
|
@pierDipi: new pull request created: #2017 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@pierDipi: new pull request created: #2018 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
When there is an environment variable override for ImageTransform, there could be `ValueFrom` set, in which case the resulting environment field would have both `Value` and `ValueFrom` which is not valid.
|
/cherry-pick release-1.16 |
|
/cherry-pick release-1.17 |
|
@houshengbo: new pull request created: #2024 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@houshengbo: new pull request created: #2025 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
When there is an environment variable override for ImageTransform, there could be
ValueFromset, in which case the resulting environment field would have bothValueandValueFromwhich is not valid.