Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.17] Unset env.ValueFrom in ImageTransform #2017

Conversation

knative-prow-robot
Copy link
Contributor

This is an automated cherry-pick of #2016

When there is an environment variable override for ImageTransform, there could be `ValueFrom` set, in which case the resulting environment field would have both `Value` and `ValueFrom` which is not valid.
@knative-prow knative-prow bot requested review from aliok and matzew March 11, 2025 16:05
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 11, 2025
Copy link

codecov bot commented Mar 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.45%. Comparing base (71d7c8c) to head (c4b4a19).
Report is 1 commits behind head on release-1.17.

❌ Your project status has failed because the head coverage (57.45%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.17    #2017      +/-   ##
================================================
- Coverage         63.88%   57.45%   -6.43%     
================================================
  Files                54       54              
  Lines              2622     2623       +1     
================================================
- Hits               1675     1507     -168     
- Misses              830     1009     +179     
+ Partials            117      107      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 11, 2025
Copy link

knative-prow bot commented Mar 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knative-prow-robot, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 11, 2025
@pierDipi
Copy link
Member

Branch doesn't seem in a good state 🧑‍🚒

Copy link

knative-prow bot commented Mar 11, 2025

@knative-prow-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
integration-tests_operator_release-1.17 c4b4a19 link true /test integration-tests
upgrade-tests_operator_release-1.17 c4b4a19 link true /test upgrade-tests
serving-upgrade-tests_operator_release-1.17 c4b4a19 link true /test serving-upgrade-tests
eventing-upgrade-tests_operator_release-1.17 c4b4a19 link true /test eventing-upgrade-tests

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@pierDipi
Copy link
Member

- Processing resources for Istio core.
✔ Istio core installed ⛵️
- Processing resources for Istiod.
- Processing resources for Istiod. Waiting for Deployment/istio-system/istiod
✔ Istiod installed 🧠
- Processing resources for CNI, Ingress gateways.
- Processing resources for CNI, Ingress gateways. Waiting for DaemonSet/kube-system/istio-cni-node
- Processing resources for CNI, Ingress gateways. Waiting for DaemonSet/kube-system/istio-cni-nod...
✔ Ingress gateways installed 🛬
- Processing resources for CNI. Waiting for DaemonSet/kube-system/istio-cni-node
✘ CNI encountered an error: failed to wait for resource: resources not ready after 5m0s: context deadline exceeded
  Error: failed to install manifests: failed to wait for resource: resources not ready after 5m0s: context deadline exceeded

@houshengbo houshengbo closed this Mar 12, 2025
@pierDipi
Copy link
Member

@houshengbo why closing this one?

@pierDipi
Copy link
Member

nevermind, I see new ones #2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants