Containerless support for Java apps #338
Conversation
eemcmullan
force-pushed
the
containerless-kantra
branch
5 times, most recently
from
20efed1
to
84bd9e1
Compare
eemcmullan
requested review from
pranavgaikwad,
shawn-hurley,
aufi,
jmle and
djzager
eemcmullan
force-pushed
the
containerless-kantra
branch
from
84bd9e1
to
07ecf95
Compare
Signed-off-by: Emily McMullan <[email protected]>
eemcmullan
force-pushed
the
containerless-kantra
branch
from
07ecf95
to
924ceea
Compare
| @@ -70,6 +68,17 @@ var ( | |||
| } | |||
| ) | |||
|
|
|||
| // analyzer container paths | |||
| const ( | |||
| RulesetPath = "/opt/rulesets" | |||
There was a problem hiding this comment.
What happens with these paths on windows?
There was a problem hiding this comment.
These paths are only used by the analyzer container, which are linux containers anyways. They aren't used in the containerless work
@shawn-hurley The first step of static report does run from main, which creates the output.js file. The script is there just because the second step required in generating the static report, building the dir and moving over the output.js file and then moving that dir into user output, requires a decent amount of chaining commands. Just thought the script made things more straight-forward, but could be wrong. |
Signed-off-by: Emily McMullan <[email protected]>
There was a problem hiding this comment.
Overall looks good and mostly fits to the konveyor/enhancements#196, LGTM.
static-report.sh
Outdated
|
|
||
| # TODO test this on windows | ||
| (cd ${HOMEDIR}/.kantra/static-report && | ||
| npm clean-install && |
There was a problem hiding this comment.
if I am not wrong, this is happening at runtime. I don't think we can expect the users to have npm installed. This should be a built artifact that's already present in .kantra/static-report. we just have to copy it into the output dir and put output.js under the copied dir.
There was a problem hiding this comment.
@pranavgaikwad the build dir doesn't have to be created for each new analysis output? Sorry if that's not what you're talking about. I wasn't sure
There was a problem hiding this comment.
yeah build dir is a one time process when we create a static-report release. The contents of the build directory remain constant for different analyses, the only variable is output.js file.
There was a problem hiding this comment.
Gotcha. Apologies - misunderstood that step. Will update
Signed-off-by: Emily McMullan <[email protected]>
Missing container-kantra-deps setup caused kantra analyze-bin command segfault. Adding check and error message to fail nicely. Related to: konveyor#338 Signed-off-by: Marek Aufart <[email protected]>
* Handle missing containerless-deps Missing container-kantra-deps setup caused kantra analyze-bin command segfault. Adding check and error message to fail nicely. Related to: #338 Signed-off-by: Marek Aufart <[email protected]> * Update .kantra subdirs validation Signed-off-by: Marek Aufart <[email protected]> * Update RulesetsLocation path from const Signed-off-by: Marek Aufart <[email protected]> --------- Signed-off-by: Marek Aufart <[email protected]>
See docs/containerless.md for testing instructions