✨ Reports: select Questionnaires #1374

gildub · 2023-09-19T16:08:16Z

Shows selection of possible questionnaires of current assessments
Pass to <Landscape>:

If "All questionnaires" option has been selected then the whole assessments list is passed
When a specific questionnaire is selected then only the assessments bound to that questionnaire are passed.

The consolidation of the risks is left to be handled by the Landscape component in following PR.

#1305

client/src/app/pages/reports/reports.tsx

codecov · 2023-09-19T17:03:40Z

Codecov Report

Patch coverage: 28.57% and project coverage change: -0.03% ⚠️

Comparison is base (bac5ce1) 41.55% compared to head (d087521) 41.53%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1374      +/-   ##
==========================================
- Coverage   41.55%   41.53%   -0.03%     
==========================================
  Files         137      137              
  Lines        4283     4290       +7     
  Branches     1035     1036       +1     
==========================================
+ Hits         1780     1782       +2     
- Misses       2415     2420       +5     
  Partials       88       88

Flag	Coverage Δ
client	`41.53% <28.57%> (-0.03%)`	⬇️
server	`∅ <ø> (∅)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
client/src/app/api/models.ts	`100.00% <ø> (ø)`
client/src/app/queries/assessments.ts	`26.08% <20.00%> (-0.75%)`	⬇️
client/src/app/api/rest.ts	`49.71% <50.00%> (+<0.01%)`	⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

client/src/app/pages/reports/reports.tsx

ibolton336

Data still being driven from questionnaires.

client/src/app/pages/reports/reports.tsx

ibolton336 · 2023-09-19T22:28:58Z

ibolton336

Reports page crashes on load when navigating from applications section

gildub · 2023-09-20T13:52:08Z

@ibolton336, loading has been addressed.

sjd78

I don't actually see where the Landscape component is sensitive to a selected questionnaire. What am I missing?

client/src/app/pages/reports/components/landscape/landscape.tsx

sjd78 · 2023-09-20T20:07:51Z

client/src/app/pages/reports/components/landscape/landscape.tsx

            <Donut
              value={landscapeData.high}
              total={applications.length}
-              color={RISK_LIST["red"].hexColor}
-              riskLabel={t("terms.highRisk")}
-              riskDescription={t("terms.unsuitableForContainers")}
+              color={RISK_LIST["green"].hexColor}
+              riskLabel={t("colors.green")}
+              // riskDescription={}
            />


If this one is 'green', should the value be switched to landscapeData.low?

client/src/app/pages/reports/reports.tsx

sjd78 · 2023-09-20T20:13:53Z

client/src/app/pages/reports/reports.tsx

-                      <Landscape />
+                      <Landscape
+                        assessments={
+                          selectedQuestionnaire === "All questionnaires"


Swap out the string for a constant for safety

client/src/app/pages/reports/reports.tsx

Signed-off-by: Gilles Dubreuil <[email protected]>

Custom assessments changes risk and confidence to be accessed from `Assessment` and not `Application`. The reports page in general, and the `Landscape` component in specific need to be updated to use risk values from `Assessment`. Summary of Change: - `Reports` - Fetch `Questionnaires` and `Assessments` to allow easy use in the Questionnaire select menu - Adjust the `Card`s to be clickable and selectable when we provide custom actions (to avoid a console warning) - `Landscape` - Use data from props instead of fetching any additional data. The containing component is now responsible for controlling the source data. - Aggregate risk data into buckets matching `Risk` options - Setup responsive layout so the donut charts wrap nicely when the view becomes narrow - `Donut` - Force `id` to be provided - Set the width to `200px` - Make sure content lines up centered in its container - Deprecated `useFetchRisks()` Enhancement: https://github.com/konveyor/enhancements/blob/90b827b68cc367284a66bf66f087d5c263487e05/enhancements/assessment-module/README.md#changes-in-the-application-reports-view Part Of: konveyor#1305 Follow Up: konveyor#1374 Signed-off-by: Scott J Dickerson <[email protected]>

# Summary Custom assessments changes risk and confidence to be accessed from `Assessment` and not `Application`. The reports page in general, and the `Landscape` component in specific need to be updated to use risk values from `Assessment`. ## Changes `Reports` - Fetch `Questionnaires` and `Assessments` to allow easy use in the Questionnaire select menu - Adjust the `Card`s to be clickable and selectable when we provide custom actions (to avoid a console warning) `Landscape` - Use data from props instead of fetching any additional data. The containing component is now responsible for controlling the source data. - Aggregate risk data into buckets matching `Risk` options - Setup responsive layout so the donut charts wrap nicely when the view becomes narrow `Donut` - Force `id` to be provided - Set the width to `200px` - Make sure content lines up centered in its container Deprecated `useFetchRisks()` ## Screenshots All questionnaires: ![image](https://github.com/konveyor/tackle2-ui/assets/3985964/9711a2b9-aa7d-4d00-b1fc-22402e97f727) Single questionnaire: ![image](https://github.com/konveyor/tackle2-ui/assets/3985964/30cb1134-c368-4843-9534-d532db2b320a) ## References Enhancement: https://github.com/konveyor/enhancements/blob/90b827b68cc367284a66bf66f087d5c263487e05/enhancements/assessment-module/README.md#changes-in-the-application-reports-view Part Of: #1305 Follow Up: #1374 Signed-off-by: Scott J Dickerson <[email protected]> Co-authored-by: Ian Bolton <[email protected]>

gildub self-assigned this Sep 19, 2023

gildub requested a review from ibolton336 September 19, 2023 16:08

ibolton336 added the Custom Assessment Items relating to custom assessment work label Sep 19, 2023

ibolton336 requested changes Sep 19, 2023

View reviewed changes

client/src/app/pages/reports/reports.tsx Outdated Show resolved Hide resolved

gildub changed the title ~~✨ Reports: select Questionnaires~~ ✨ [WIP] Reports: select Questionnaires Sep 19, 2023

ibolton336 reviewed Sep 19, 2023

View reviewed changes

client/src/app/pages/reports/reports.tsx Outdated Show resolved Hide resolved

ibolton336 reviewed Sep 19, 2023

View reviewed changes

client/src/app/pages/reports/reports.tsx Outdated Show resolved Hide resolved

gildub changed the title ~~✨ [WIP] Reports: select Questionnaires~~ ✨ Reports: select Questionnaires Sep 19, 2023

gildub requested a review from ibolton336 September 19, 2023 21:09

ibolton336 requested changes Sep 19, 2023

View reviewed changes

client/src/app/pages/reports/reports.tsx Show resolved Hide resolved

gildub requested a review from ibolton336 September 19, 2023 21:22

ibolton336 requested changes Sep 19, 2023

View reviewed changes

sjd78 requested changes Sep 20, 2023

View reviewed changes

gildub added 10 commits September 21, 2023 10:12

Reports: select Questionnaires

63628eb

Signed-off-by: Gilles Dubreuil <[email protected]>

select from assessments; set donut colors

02998ab

Signed-off-by: Gilles Dubreuil <[email protected]>

Reduce assessment list to unique questionnaires

a7ed5d0

Signed-off-by: Gilles Dubreuil <[email protected]>

Pass specific questionnaire to LandScape

9b0a143

Signed-off-by: Gilles Dubreuil <[email protected]>

LandScape gets assessments from selection

57485c0

Signed-off-by: Gilles Dubreuil <[email protected]>

Use isAssessmentsFetching

f17b04a

Signed-off-by: Gilles Dubreuil <[email protected]>

check assessments fetchError

89c578e

Signed-off-by: Gilles Dubreuil <[email protected]>

Adjust landscapeData

981fead

Signed-off-by: Gilles Dubreuil <[email protected]>

Rename and default select value is constant

4277f71

Signed-off-by: Gilles Dubreuil <[email protected]>

Handle empty assessment questionnaire case and sort list

228bded

Signed-off-by: Gilles Dubreuil <[email protected]>

gildub requested review from sjd78 and ibolton336 September 21, 2023 11:49

Refactor answeredQuestionnaires

d13e446

Signed-off-by: Gilles Dubreuil <[email protected]>

ibolton336 approved these changes Sep 21, 2023

View reviewed changes

sjd78 approved these changes Sep 21, 2023

View reviewed changes

Merge branch 'main' into reports-questionnaires-dropdown

d087521

sjd78 merged commit 44a40e8 into konveyor:main Sep 21, 2023
6 checks passed

sjd78 mentioned this pull request Sep 21, 2023

Reports page api updates #1305

Closed

4 tasks

gildub deleted the reports-questionnaires-dropdown branch September 21, 2023 20:01

sjd78 mentioned this pull request Sep 22, 2023

✨ Reports - Current Landscape update risk handling #1395

Merged

This was referenced Nov 22, 2023

operator konveyor-operator (0.3.0-beta.3) k8s-operatorhub/community-operators#3570

Merged

operator konveyor-operator (0.3.0-beta.3) redhat-openshift-ecosystem/community-operators-prod#3652

Merged

This was referenced Jan 23, 2024

operator konveyor-operator (0.3.0) k8s-operatorhub/community-operators#3793

Merged

operator konveyor-operator (0.3.0) redhat-openshift-ecosystem/community-operators-prod#3927

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

✨ Reports: select Questionnaires #1374

✨ Reports: select Questionnaires #1374

gildub commented Sep 19, 2023 •

edited

Loading

codecov bot commented Sep 19, 2023 •

edited

Loading

ibolton336 left a comment

ibolton336 commented Sep 19, 2023

ibolton336 left a comment

gildub commented Sep 20, 2023

sjd78 left a comment

sjd78 Sep 20, 2023

sjd78 Sep 20, 2023

✨ Reports: select Questionnaires #1374

✨ Reports: select Questionnaires #1374

Conversation

gildub commented Sep 19, 2023 • edited Loading

codecov bot commented Sep 19, 2023 • edited Loading

Codecov Report

ibolton336 left a comment

Choose a reason for hiding this comment

ibolton336 commented Sep 19, 2023

ibolton336 left a comment

Choose a reason for hiding this comment

gildub commented Sep 20, 2023

sjd78 left a comment

Choose a reason for hiding this comment

sjd78 Sep 20, 2023

Choose a reason for hiding this comment

sjd78 Sep 20, 2023

Choose a reason for hiding this comment

gildub commented Sep 19, 2023 •

edited

Loading

codecov bot commented Sep 19, 2023 •

edited

Loading