Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👻 Remove shared app filter and unused menuActions #1402

Merged
merged 4 commits into from
Sep 27, 2023

Conversation

ibolton336
Copy link
Member

  • Removes some old code I noticed after the dropdown update & analysis table PRs were merged
  • Menu actions are no longer used in the page header component and have been moved to the toolbar
  • Removes old shared app filter hook that is no longer in use

@ibolton336 ibolton336 force-pushed the remove-deprecated-files branch from 168fa04 to 0631de7 Compare September 26, 2023 14:19
@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (9cf7840) 41.23% compared to head (e74a92a) 41.05%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1402      +/-   ##
==========================================
- Coverage   41.23%   41.05%   -0.18%     
==========================================
  Files         138      137       -1     
  Lines        4351     4338      -13     
  Branches     1045     1043       -2     
==========================================
- Hits         1794     1781      -13     
  Misses       2469     2469              
  Partials       88       88              
Flag Coverage Δ
client 41.05% <ø> (-0.18%) ⬇️
server ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
client/src/app/components/PageHeader.tsx 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ibolton336 ibolton336 force-pushed the remove-deprecated-files branch from 02d69b6 to 05581fe Compare September 26, 2023 14:55
@ibolton336 ibolton336 force-pushed the remove-deprecated-files branch from 23c95f5 to 88314d2 Compare September 26, 2023 14:55
Copy link
Collaborator

@gitdallas gitdallas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i noticed menuActions was only given empty arrays as well (had to put some fake data in to test it locally), but left it in assuming that there may be a need for it coming up. if not, lgtm.

@ibolton336
Copy link
Member Author

i noticed menuActions was only given empty arrays as well (had to put some fake data in to test it locally), but left it in assuming that there may be a need for it coming up. if not, lgtm.

Appreciate it!

Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ibolton336 ibolton336 merged commit e269b74 into konveyor:main Sep 27, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants