-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
👻 Remove shared app filter and unused menuActions #1402
Conversation
ibolton336
commented
Sep 26, 2023
- Removes some old code I noticed after the dropdown update & analysis table PRs were merged
- Menu actions are no longer used in the page header component and have been moved to the toolbar
- Removes old shared app filter hook that is no longer in use
168fa04
to
0631de7
Compare
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1402 +/- ##
==========================================
- Coverage 41.23% 41.05% -0.18%
==========================================
Files 138 137 -1
Lines 4351 4338 -13
Branches 1045 1043 -2
==========================================
- Hits 1794 1781 -13
Misses 2469 2469
Partials 88 88
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
02d69b6
to
05581fe
Compare
Signed-off-by: ibolton336 <[email protected]>
23c95f5
to
88314d2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i noticed menuActions was only given empty arrays as well (had to put some fake data in to test it locally), but left it in assuming that there may be a need for it coming up. if not, lgtm.
Appreciate it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM