🌱 ci-repo: concurrency limits, codecov upload #2056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Setup concurrency on the ci-repo.yml workflow so
rapid updates to a PR will have old/pending CI runs
just cancel (saving resources)
- Allow the codecov action to upload on any run. This
should allow the codecov reports on PRs be accurate
based on the current commit on main (or PR target branch)
Signed-off-by: Scott J Dickerson <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2056 +/- ##
==========================================
+ Coverage 39.20% 42.53% +3.33%
==========================================
Files 146 171 +25
Lines 4857 5504 +647
Branches 1164 1375 +211
==========================================
+ Hits 1904 2341 +437
- Misses 2939 3046 +107
- Partials 14 117 +103
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
rszwajko
approved these changes
Aug 22, 2024
| @@ -61,14 +65,14 @@ jobs: | |||
| run: npm run test -- --coverage --watchAll=false | |||
|
|
|||
| - name: Upload to codecov (client) | |||
| if: ${{ github.event.pull_request }} | |||
| # if: ${{ github.event.pull_request }} | |||
There was a problem hiding this comment.
our PR branches are mostly short-lived - I'm not sure if this is the main reason of codecov being out of synch (as of this PR its 200+ commits). Let's see it in action.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setup concurrency on the ci-repo.yml workflow so rapid updates to a PR will have old/pending CI runs just cancel (saving resources)
Allow the codecov action to upload on any run. This should allow the codecov reports on PRs be accurate based on the current commit on main (or PR target branch)
Fixes: #1820