Add code contributors from git history #160
Conversation
yevhenorlov
force-pushed
the
add-all-contributors
branch
from
1789d67 to
8c29f5a
Compare
|
btw, is it just automatically generating list of committers into the repo? I'm wondering because there was definitely some code from https://github.com/MashaTimmpa/3_kottans at one point (she was the one responsible for some previous redesign, IIRC) |
At this step I'm adding only contributors from git history. (see #161 for roadmap). Currrently Of course, if there's some contributions that are not visible in that data, we should add them manually. |
| ] | ||
| }, | ||
| { | ||
| "login": "m1n0s", |
There was a problem hiding this comment.
I see a lot of people, who did not contributed into new website.
What the background of this PR?
There was a problem hiding this comment.
We've discussed at some point that for a lot of people who contributed to Kottans their work is not visible, because it was removed from current state of the repo.
While that was a necessary decision, I think we still should recognize their past work. IMO this is a good place to do that.
Kottans are a community with a long history, that should be visible 💪
There was a problem hiding this comment.
As far as I see this right now, we have core, lectors and mentors, who mentioned on a website.
Contributers into this repo are contributers into website, who spent a lot of personal time and effort into it. I don't see any reason why we should bring everyone here. Probably we should find a better way to do this.
Pls, make an RFC in kottans_ongoing_projects, we should discuss, how to mention everyone.
There was a problem hiding this comment.
Sure, will do. Closing this for now
There was a problem hiding this comment.
@zonzujiro most of those contributions were created when mentors were adding themselves to mentors data yaml
There was a problem hiding this comment.
@sudodoki this is exactly what we are discussing right now #161 (comment) :)
yevhenorlov
changed the title
Issue: #161