Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add code contributors from git history #160
Add code contributors from git history #160
Changes from all commits
32defb4
d70cb2d
0d70206
05ec192
16774d0
840b258
85c1f46
ec83137
c0a9bf1
a3f8be8
6559a5c
c59aaa8
c66bb10
9021fd5
619db31
cf555d5
134ad3c
3165e0a
b84f9f3
418122c
fd0607c
25adf53
7e0d97b
ba1496b
a62ca8d
bad076c
7c30953
c5fc38c
2ab0dee
274d720
0942af4
8c29f5a
66700e3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see a lot of people, who did not contributed into new website.
What the background of this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've discussed at some point that for a lot of people who contributed to Kottans their work is not visible, because it was removed from current state of the repo.
While that was a necessary decision, I think we still should recognize their past work. IMO this is a good place to do that.
Kottans are a community with a long history, that should be visible 💪
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I see this right now, we have core, lectors and mentors, who mentioned on a website.
Contributers into this repo are contributers into website, who spent a lot of personal time and effort into it. I don't see any reason why we should bring everyone here. Probably we should find a better way to do this.
Pls, make an RFC in kottans_ongoing_projects, we should discuss, how to mention everyone.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, will do. Closing this for now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zonzujiro most of those contributions were created when mentors were adding themselves to mentors data yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sudodoki this is exactly what we are discussing right now #161 (comment) :)