Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ New CLI UX #37

Merged
merged 48 commits into from
Feb 9, 2025
Merged

✨ New CLI UX #37

merged 48 commits into from
Feb 9, 2025

Conversation

dipankardas011
Copy link
Member

@dipankardas011 dipankardas011 commented Jan 28, 2025

🗒️ Changelog

  • elimating init() based cli code structure
  • changing based on ksctl/v2@main
  • ksctl config for storing user perference for storage driver
  • Moved credentials logic from ksctl/ksctl/pkg/storage -> ksctl/cli/pkg/config Feat/new creds ksctl#514

🏋🏼 Issues

📎 Related Issues

🚀 Task List

  • Addon support and other cli command changes

🔍 Review Checklist

  • Code follows project style guidelines
  • Added/updated tests
  • Ran tests locally
  • Updated documentation
  • Checked Contribution Guidelines

📸 Screenshots/Recordings

📌 Additional Notes


💡 PR best practices
  • Keep changes focused and atomic
  • Update tests and documentation
  • Check for conflicts with main branch
  • Respond promptly to review comments
  • Follow project coding standards
  • Make sure you are using pre-commit for that run this command $ pre-commit install

@github-actions github-actions bot added the go label Jan 28, 2025
Signed-off-by: Dipankar Das <[email protected]>
Signed-off-by: Dipankar Das <[email protected]>
Signed-off-by: Dipankar Das <[email protected]>
Signed-off-by: Dipankar Das <[email protected]>
@dipankardas011 dipankardas011 changed the title New cli ✨ New CLI UX Jan 28, 2025
@dipankardas011 dipankardas011 mentioned this pull request Jan 30, 2025
5 tasks
Signed-off-by: Dipankar Das <[email protected]>
Signed-off-by: Dipankar Das <[email protected]>
Signed-off-by: Dipankar Das <[email protected]>
@dipankardas011
Copy link
Member Author

Updated the pipeline for docs https://docs.dev.ksctl.com/docs/reference/

@dipankardas011
Copy link
Member Author

dipankardas011 commented Feb 3, 2025

Here is the 🎇 New CLI UX 🎉

image

Signed-off-by: Dipankar Das <[email protected]>
@dipankardas011
Copy link
Member Author

When a user is onboarded to ksctl they need

ksctl configure

command to set their customization

one more is for what kind of workloads they want to run on the cluster
like is it cpu intensive, memory intensive according to that we can use our labels added to our vms to filter out them

Signed-off-by: Dipankar Das <[email protected]>
Signed-off-by: Dipankar Das <[email protected]>
Signed-off-by: Dipankar Das <[email protected]>
Signed-off-by: Dipankar Das <[email protected]>
Signed-off-by: Dipankar Das <[email protected]>
@dipankardas011 dipankardas011 removed the go label Feb 9, 2025
Signed-off-by: Dipankar Das <[email protected]>
@github-actions github-actions bot added the go label Feb 9, 2025
Signed-off-by: Dipankar Das <[email protected]>
@dipankardas011 dipankardas011 marked this pull request as ready for review February 9, 2025 16:25
@dipankardas011 dipankardas011 merged commit 046ec7f into main Feb 9, 2025
10 checks passed
@dipankardas011 dipankardas011 linked an issue Feb 10, 2025 that may be closed by this pull request
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Feature]: CLI menu driven user flow
1 participant